Update enum decode for cluster object #10257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
changed the title
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon and
vivien-apple
bzbarsky-apple
approved these changes
Oct 5, 2021
yunhanw-google
force-pushed
the
feature/update_enum_cluster_object
branch
from
5d13c3c to
cbd264a
Compare
andy31415
approved these changes
Oct 5, 2021
mrjerryjohns
approved these changes
Oct 5, 2021
tcarmelveilleux
approved these changes
Oct 5, 2021
emargolis
approved these changes
Oct 5, 2021
msandstedt
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since #10219 Add TLVReader::Get for enums, we can simplify enum decode in cluster object zapt
Change overview
see above
Testing
The existing test covers