Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RPC support for the efr32 lock app #10232

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Remove RPC support for the efr32 lock app #10232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b00b7
lock app does not compile with -rpc
andy31415 Oct 5, 2021
7dbd2c5
Fix extra ,
andy31415 Oct 5, 2021
76063e6
Fix unit tests
andy31415 Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@
"android-x86-chip-tool",
"efr32-brd4161a-light-rpc",
"efr32-brd4161a-light",
"efr32-brd4161a-lock-rpc",
"efr32-brd4161a-lock",
"efr32-brd4161a-window-covering",
"esp32-c3devkit-all-clusters",
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/build/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ def Efr32Targets():
board=Efr32Board.BRD4161A)

yield efr_target.Extend('window-covering', app=Efr32App.WINDOW_COVERING)
yield efr_target.Extend('lock', app=Efr32App.LOCK)

rpc_aware_targets = [
efr_target.Extend('light', app=Efr32App.LIGHT),
efr_target.Extend('lock', app=Efr32App.LOCK),
]

for target in rpc_aware_targets:
Expand Down
1 change: 0 additions & 1 deletion scripts/build/testdata/all_targets_except_host.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ android-x86-chip-tool
efr32-brd4161a-light
efr32-brd4161a-light-rpc
efr32-brd4161a-lock
efr32-brd4161a-lock-rpc
efr32-brd4161a-window-covering
esp32-c3devkit-all-clusters
esp32-devkitc-all-clusters
Expand Down
6 changes: 0 additions & 6 deletions scripts/build/testdata/build_all_except_host.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ gn gen --check --fail-on-unused-args --root={root}/examples/lighting-app/efr32 '
# Generating efr32-brd4161a-lock
gn gen --check --fail-on-unused-args --root={root}/examples/lock-app/efr32 '--args=efr32_board="BRD4161A"' {out}/efr32-brd4161a-lock

# Generating efr32-brd4161a-lock-rpc
gn gen --check --fail-on-unused-args --root={root}/examples/lock-app/efr32 '--args=efr32_board="BRD4161A" import("//with_pw_rpc.gni")' {out}/efr32-brd4161a-lock-rpc

# Generating efr32-brd4161a-window-covering
gn gen --check --fail-on-unused-args --root={root}/examples/window-app/efr32 '--args=efr32_board="BRD4161A"' {out}/efr32-brd4161a-window-covering

Expand Down Expand Up @@ -255,9 +252,6 @@ ninja -C {out}/efr32-brd4161a-light-rpc
# Building efr32-brd4161a-lock
ninja -C {out}/efr32-brd4161a-lock

# Building efr32-brd4161a-lock-rpc
ninja -C {out}/efr32-brd4161a-lock-rpc

# Building efr32-brd4161a-window-covering
ninja -C {out}/efr32-brd4161a-window-covering

Expand Down