Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EFR32 builds - window covering is not rpc-aware #10227

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Fix EFR32 builds - window covering is not rpc-aware #10227

merged 3 commits into from
Oct 5, 2021

Conversation

andy31415
Copy link
Contributor

Problem

  • window covering app does not support rpc
  • 'light' prefix being prepended for every EFR32 app

Change overview

Remove -rpc variant for the window cover app
Fix the light prefix typo

Testing

Ran

./scripts/build/build_examples.py --target-glob 'efr32*' gen

unit tests

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Oct 5, 2021
@restyled-io restyled-io bot mentioned this pull request Oct 5, 2021
Closed
@andy31415
Copy link
Contributor Author

Hotfix as this fixes a CI build.

@andy31415 andy31415 merged commit 1fee66e into project-chip:master Oct 5, 2021
@andy31415 andy31415 deleted the fix_rpc branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review scripts vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @saurabhst