-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of nullptr for 0 length plaintext/ciphertext in crypto #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon,
vivien-apple and
woody-apple
October 4, 2021 17:46
Size increase report for "gn_qpg-example-build" from ed8d28c
Full report output
|
andy31415
approved these changes
Oct 4, 2021
Size increase report for "nrfconnect-example-build" from ed8d28c
Full report output
|
Size increase report for "esp32-example-build" from ed8d28c
Full report output
|
tcarmelveilleux
approved these changes
Oct 4, 2021
msandstedt
approved these changes
Oct 4, 2021
saurabhst
approved these changes
Oct 4, 2021
woody-apple
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
OpenSSL APIs do not support using
nullptr
for 0 length plaintext for encrypt, and 0 length cipher-text for decrypt operations. Expectation is to use an empty string instead of nullptr.This PR uses a temporary empty string if the user has provided a nullptr and 0 length for the corresponding value. It also adds more checks and tests to ensure that API behaves as expected.
Testing
Added more unit tests to
CHIPCryptoPALTest
suite.