Add a placeholder example for generating tests app #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add examples/placeholder with some default zap file that can be compiled with ./scripts/examples/gn_build_test_example.sh app1
vivien-apple
force-pushed
the
Test_AddTemplateFolder
branch
from
a166d32 to
febab55
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
shana-apple,
tcarmelveilleux,
turon and
woody-apple
woody-apple
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For CI, it may be useful to have multiple applications sharing the same codebase but built from a different ZAP configuration.
Futhermore, it may be useful to make it possible to configure some macros such as the discriminator.
Change overview
examples/placeholder/linux/scripts/examples/gn_build_test_example.shscripts that can be run such asscripts/examples/gn_build_test_example.sh app1Testing
This is only tested locally. I'm planning to use that as a base for the YAML CI, but other may make uses of it today to check what's missing in the SDK when trying to build a ZAP file without any extra code.