Remove vestigial RemoveAllFabrics and UpdateOpCert callbacks. #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
This was missed when RemoveAllFabrics was removed and UpdateOpCert renamed.
bzbarsky-apple
force-pushed
the
nix-remove-all-fabrics
branch
from
1ce8d37 to
e0c66c5
Compare
bzbarsky-apple
changed the title
emargolis
approved these changes
Oct 2, 2021
jmartinez-silabs
approved these changes
Oct 2, 2021
saurabhst
approved these changes
Oct 2, 2021
saurabhst
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed when RemoveAllFabrics was removed and UpdateOpCert renamed.
Problem
Functions that should not be there.
Change overview
Remove them.
Testing
Tree compiles.