Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Just-In-Time Provisioning feature #10136

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Cleanup Just-In-Time Provisioning feature #10136

merged 2 commits into from
Oct 1, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Oct 1, 2021

Problem

What is being fixed? Examples:

  • Just-In-Time Provisioning is a company internal feature inherited from legacy weave implementation. This feature is not within the Matter spec and should be removed from Matter SDK.

Change overview

Cleanup Just-In-Time Provisioning feature

Testing

How was this tested? (at least one bullet point required)

  • This feature is not activated in Matter SDK and the regression check is covered by CI

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "gn_qpg-example-build" from ad35474

File Section File VM
chip-qpg6100-lighting-example.out .text -24 -24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,24
.debug_ranges,0,-24
.text,-24,-24
.debug_line,0,-60
.debug_str,0,-181
.debug_loc,0,-191
.debug_info,0,-980

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "esp32-example-build" from ad35474

File Section File VM
chip-all-clusters-app.elf .flash.text -32 -32
chip-all-clusters-app.elf .flash.rodata -72 -72
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,112
.shstrtab,0,-1
.riscv.attributes,0,-2
.dram0.data,0,-8
.symtab,0,-16
.flash.text,-32,-32
.debug_line,0,-41
.debug_ranges,0,-48
.flash.rodata,-72,-72
.strtab,0,-79
.debug_loc,0,-170
.debug_str,0,-505
.debug_info,0,-2054


@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "nrfconnect-example-build" from ad35474

File Section File VM
chip-lock.elf device_handles -4 -4
chip-lock.elf rodata -24 -20
chip-lock.elf text -28 -28
chip-shell.elf device_handles 12 12
chip-shell.elf rodata -24 -20
chip-shell.elf text -28 -28
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,-4,-4
.debug_abbrev,0,-18
.debug_ranges,0,-24
rodata,-20,-24
text,-28,-28
.symtab,0,-32
.debug_line,0,-62
.strtab,0,-80
.debug_loc,0,-319
.debug_str,0,-509
.debug_info,0,-1036

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
device_handles,12,12
.debug_abbrev,0,-18
.debug_ranges,0,-24
rodata,-20,-24
text,-28,-28
.symtab,0,-32
.debug_line,0,-64
.strtab,0,-80
.debug_loc,0,-199
.debug_str,0,-509
.debug_info,0,-858


@andy31415 andy31415 merged commit 3a5f1e0 into project-chip:master Oct 1, 2021
@yufengwangca yufengwangca deleted the pr/jit/clean branch October 1, 2021 22:54
@@ -150,8 +139,7 @@ class GenericConfigurationManagerImpl
kIsServiceProvisioned = 0x01,
kIsMemberOfFabric = 0x02,
kIsPairedToAccount = 0x04,
kOperationalDeviceCredentialsProvisioned = 0x08,
kUseManufacturerCredentialsAsOperational = 0x10,
kUseManufacturerCredentialsAsOperational = 0x08,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants