-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependencies on FabricTable objects #10126
Merged
andy31415
merged 1 commit into
project-chip:master
from
pan-apple:cleanup-fabrictable-includes
Sep 30, 2021
Merged
Remove unnecessary dependencies on FabricTable objects #10126
andy31415
merged 1 commit into
project-chip:master
from
pan-apple:cleanup-fabrictable-includes
Sep 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon and
vivien-apple
September 30, 2021 19:43
woody-apple
approved these changes
Sep 30, 2021
msandstedt
approved these changes
Sep 30, 2021
jmartinez-silabs
approved these changes
Sep 30, 2021
Size increase report for "nrfconnect-example-build" from 40ac48e
Full report output
|
Size increase report for "esp32-example-build" from 40ac48e
Full report output
|
tcarmelveilleux
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A bunch of code is including
FabricTable.h
that's not really needed. The code could use some cleanup.Change overview
Removed unnecessary dependency on classes in
FabricTable.h
file. Also moved FabricTable objects out ofTransport
namespace. Intention is to eventually move it out ofsrc/transport
to higher in the stack.Testing
Ran
gn_build.sh
andgn_tests.sh
to ensure the builds and tests are not impacted.Build m5stack image to test the device build.
Performed commissioning of m5stack using chip-tool
CI to test other device builds.