Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ResetEthNetworkDiagnosticsCounts method in ConnectivityManager #10122

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Implement the ResetEthNetworkDiagnosticsCounts method in ConnectivityManager #10122

merged 2 commits into from
Oct 1, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Sep 30, 2021

Problem

What is being fixed? Examples:

  • Ethernet diagnostic attributes are hooked to SDK-internal logic to produce attribute values, if the platform does not want to provide one we fall back to asking the attribute store.

  • emberAfEthernetNetworkDiagnosticsClusterResetCountsCallback method currently only reset the counts within attribute store, we also need to calls the reset counters api on the platform side to reset the count if the attribute values are produced by the platform.

Change overview

Implement the ResetEthNetworkDiagnosticsCounts method for the zcl com…

Testing

How was this tested? (at least one bullet point required)

  • On Linux simulation, the Ethernet stats are shared by all running programs, the current running program with matter stack does not have the permission to reset those counts, so just non-op within this callback

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "gn_qpg-example-build" from 43b3d3c

File Section File VM
chip-qpg6100-lighting-example.out .text -412 -412
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,821
[Unmapped],0,412
.debug_str,0,245
.debug_ranges,0,24
.shstrtab,0,-3
.debug_frame,0,-4
.debug_loc,0,-19
.debug_abbrev,0,-36
.debug_line,0,-171
.symtab,0,-176
.text,-412,-412
.strtab,0,-417

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "esp32-example-build" from 43b3d3c

File Section File VM
chip-all-clusters-app.elf .flash.rodata -160 -160
chip-all-clusters-app.elf .flash.text -284 -284
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,949
[Unmapped],0,444
.debug_str,0,245
.shstrtab,0,1
.riscv.attributes,0,-2
.debug_loc,0,-9
.debug_frame,0,-12
.debug_abbrev,0,-36
.symtab,0,-80
.flash.rodata,-160,-160
.flash.text,-284,-284
.debug_line,0,-407
.strtab,0,-417


@yufengwangca yufengwangca merged commit 3d70836 into project-chip:master Oct 1, 2021
@yufengwangca yufengwangca deleted the pr/cluster/eth branch October 4, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants