-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ResetEthNetworkDiagnosticsCounts method in ConnectivityManager #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
vivien-apple
September 30, 2021 19:05
tcarmelveilleux
approved these changes
Sep 30, 2021
woody-apple
approved these changes
Sep 30, 2021
Size increase report for "gn_qpg-example-build" from 43b3d3c
Full report output
|
saurabhst
approved these changes
Oct 1, 2021
Size increase report for "esp32-example-build" from 43b3d3c
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Ethernet diagnostic attributes are hooked to SDK-internal logic to produce attribute values, if the platform does not want to provide one we fall back to asking the attribute store.
emberAfEthernetNetworkDiagnosticsClusterResetCountsCallback method currently only reset the counts within attribute store, we also need to calls the reset counters api on the platform side to reset the count if the attribute values are produced by the platform.
Change overview
Implement the ResetEthNetworkDiagnosticsCounts method for the zcl com…
Testing
How was this tested? (at least one bullet point required)