-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msg] Authenticate message before counter and duplicate processing. #10095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
September 30, 2021 03:28
msandstedt
approved these changes
Sep 30, 2021
saurabhst
approved these changes
Sep 30, 2021
emargolis
approved these changes
Sep 30, 2021
tcarmelveilleux
approved these changes
Sep 30, 2021
turon
force-pushed
the
msg/decrypt-before-counter
branch
from
September 30, 2021 14:48
d1d5a39
to
516f8a4
Compare
turon
force-pushed
the
msg/decrypt-before-counter
branch
from
September 30, 2021 15:07
516f8a4
to
ac1b4e9
Compare
Size increase report for "gn_qpg-example-build" from 12a35d8
Full report output
|
yufengwangca
approved these changes
Sep 30, 2021
Size increase report for "esp32-example-build" from 12a35d8
Full report output
|
Size increase report for "nrfconnect-example-build" from 12a35d8
Full report output
|
andy31415
approved these changes
Oct 4, 2021
LuDuda
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per spec, if a message doesn't self-authenticate, it can be discarded ahead of any counter, replay, or duplicate processing.
Change overview
Performs message decryption/authentication before counter processing as required by specification.
Also renaming
SecureMessageCodec::Encode/Decode
toSecureMessageCodec::Encrypt/Decrypt
to better differentiate crypto processing of a message from more benign header processing and parsing. The initial entry point for message decryption can now be found via regex search forMessage.*Decrypt
for example.Testing
Only standard ./gn_build.sh unit test suite.