Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Add wifi ap and station functionality #10049

Merged
merged 9 commits into from
Oct 19, 2021
Merged

[Tizen] Add wifi ap and station functionality #10049

merged 9 commits into from
Oct 19, 2021

Conversation

hyunuktak
Copy link
Contributor

Problem

The wifi ap and station functionality is not implemented.

Change overview

Add wifi ap and station functionality in Tizen platform.

Testing

lighting-app example.

woody-apple
woody-apple previously requested changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoftAP is not supported by the SDK for v1.0. Is this change required? It won't be able to verified and certified without SDK support...

@restyled-io restyled-io bot mentioned this pull request Oct 1, 2021
Closed
@hyunuktak
Copy link
Contributor Author

SoftAP is not supported by the SDK for v1.0. Is this change required? It won't be able to verified and certified without SDK support...

I removed the contents related to softap in this patch.
Thanks for your comment.

@msandstedt
Copy link
Contributor

SoftAP is not supported by the SDK for v1.0. Is this change required? It won't be able to verified and certified without SDK support...

I removed the contents related to softap in this patch. Thanks for your comment.

@woody-apple ,

Does this satisfy the change request?

@hyunuktak hyunuktak requested a review from woody-apple October 8, 2021 01:06
@hyunuktak
Copy link
Contributor Author

hyunuktak commented Oct 13, 2021 •
edited
Loading

SoftAP is not supported by the SDK for v1.0. Is this change required? It won't be able to verified and certified without SDK support...

@woody-apple As your comment, i removed the contents related to softap in this patch. please review it.

@dh79pyun
Copy link
Contributor

dh79pyun commented Oct 15, 2021 •
edited
Loading

SoftAP is not supported by the SDK for v1.0. Is this change required? It won't be able to verified and certified without SDK support...

We modified the patchset as the change request.

@woody-apple, @bzbarsky-apple, @vivien-apple,
Can you review this PR again?
Based on this PR, we will raise other Tizen patchsets.

bzbarsky-apple
bzbarsky-apple approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this makes a lot more sense now.

@bzbarsky-apple bzbarsky-apple dismissed woody-apple’s stale review October 19, 2021 05:36

SoftAP bits are gone from the PR.

@bzbarsky-apple bzbarsky-apple merged commit 4c7f664 into project-chip:master Oct 19, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 19, 2021
@hyunuktak @JasonLiuZhuoCheng
[Tizen] Add wifi ap and station functionality (project-chip#10049)
48530e3 
* Add wifi ap and station functionality

Signed-off-by: hyunuktak <[email protected]>

* Apply comment for WiFi

* Apply comment for SoftAP

* Apply a comment

* Restyle

* Apply a comment for key length

* Remove exit section

* Set flag as 0 for WIFI_AP

* Apply a comment for setting wifi station mode
@hyunuktak hyunuktak deleted the master-dev branch November 17, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semun-lee semun-lee semun-lee left review comments

@andy31415 andy31415 andy31415 left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@shana-apple shana-apple Awaiting requested review from shana-apple

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hyunuktak @msandstedt @dh79pyun @tcarmelveilleux @andy31415 @semun-lee @woody-apple @bzbarsky-apple