OTA Requestor and Provider fixes #10037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ActionTime
Add the following command line options to the Provider Linux executable:
-q/--QueryImageBehavior <UpdateAvailable | Busy | UpdateNotAvailable>
Status value in the Query Image Response
-d/--DelayedActionTimeSec <time>
Value in seconds for the DelayedActionTime in the Query Image Response
holbrookt
suggested changes
Sep 28, 2021
examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp
Outdated
Show resolved
Hide resolved
examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp
Outdated
Show resolved
Hide resolved
examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp
Outdated
Show resolved
Hide resolved
examples/ota-provider-app/ota-provider-common/OTAProviderExample.h
Outdated
Show resolved
Hide resolved
examples/ota-requestor-app/ota-requestor-common/BDXDownloader.cpp
Outdated
Show resolved
Hide resolved
Also revert to treating AckEOFReceived as an unexpected event on the Downloader
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple and
woody-apple
msandstedt
approved these changes
Sep 29, 2021
holbrookt
approved these changes
Sep 29, 2021
woody-apple
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
[ota-provider-app] Add configuration for sending "Busy" status and DelayedActionTime #9478
[ota-requestor-app] Close the BDX ExchangeContext when transfer is over #9525
Change overview
Fix for 9478: Add configuration for sending "Busy" status and DelayedActionTime. Add the following command line options to the Provider Linux executable:
-q/--QueryImageBehavior <UpdateAvailable | Busy | UpdateNotAvailable>
Status value in the Query Image Response
-d/--DelayedActionTimeSec
Value in seconds for the DelayedActionTime in the Query Image Response
Fix for 9525: Close the BDX ExchangeContext when transfer is over. Call mExchangeCtx->Close() in cases of transfer timeout, internal error and status received.
Testing
Tested with the Provider/Requestor apps on Linux. Verified the scenarios for successful file transfer, transfer timeout, various command line parameter combinations.