Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFR32 unit tests #10031

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Fix EFR32 unit tests #10031

merged 1 commit into from
Sep 30, 2021

Conversation

rgoliver
Copy link

Problem

EFR 32 unit tests are failing:

<efr32 > Failed do a malloc on HEAP. Is it too small ?
<info  > [-] 
FREERTOS ASSERT ( (volatile void *) NULL )

Change overview

-Remove CHIPCryptoPALTest which was using too much heap and causing the crash.

Testing

Ran EFR32 unit tests on EFR32MG12 board and verified it passed all 228 tests.

Remove CHIPCryptoPALTest which was using too much heap and causing
a crash.
Copy link
Member

@jmartinez-silabs jmartinez-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgoliver You should be able to increase the heap for the test Driver without affecting other examples.
In src/test_driver/efr32/include/FreeRTOSConfig.h

Increase this value to the test needs.
#define configTOTAL_HEAP_SIZE ((size_t)(16 * 1024))

If possible, I would keep the test in. The MG12 has 256kB of ram.

@rgoliver
Copy link
Author

@rgoliver You should be able to increase the heap for the test Driver without affecting other examples. In src/test_driver/efr32/include/FreeRTOSConfig.h

Increase this value to the test needs. #define configTOTAL_HEAP_SIZE ((size_t)(16 * 1024))

If possible, I would keep the test in. The MG12 has 256kB of ram.

Increasing HEAP to 80k (max I could do before overflow) still crashes with the same error; not sure why this test is using so much. If we want to fix the test instead of disabling it, someone will need to dig in a bit more into what is actually breaking. I won't have time to investigate until closer to the end of the week, but someone else is welcome to pick it up before then if they want.

@jmartinez-silabs
Copy link
Member

@rgoliver
Increasing HEAP to 80k (max I could do before overflow) still crashes with the same error; not sure why this test is using so much. If we want to fix the test instead of disabling it, someone will need to dig in a bit more into what is actually breaking. I won't have time to investigate until closer to the end of the week, but someone else is welcome to pick it up before then if they want.

Oh wow, even at 80K it fails. That is suprising. I won't be able to look at it this week. But I am interested in this test case and why it needs so much heap.

I will remove my request for change and we can investigate this later on.

@andy31415 andy31415 merged commit 643d60b into project-chip:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants