Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DebugText to CHAR_STRING once strings are supported in command/response f... #8704

Closed
todo bot opened this issue Jul 29, 2021 · 0 comments · Fixed by #10745
Closed

Change DebugText to CHAR_STRING once strings are supported in command/response f... #8704

todo bot opened this issue Jul 29, 2021 · 0 comments · Fixed by #10745
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Jul 29, 2021

// TODO: Change DebugText to CHAR_STRING once strings are supported in command/response fields
ReturnErrorOnFailure(writer->Put(TLV::ContextTag(2), debug_text));
return commandObj->FinishCommand();
}
EmberAfNodeOperationalCertStatus ConvertToNOCResponseStatus(CHIP_ERROR err)
{
if (err == CHIP_NO_ERROR)
{
return EMBER_ZCL_NODE_OPERATIONAL_CERT_STATUS_SUCCESS;
}


This issue was generated by todo based on a TODO comment in d97b1e8 when #8334 was merged. cc @pan-apple.
@todo todo bot added the todo label Jul 29, 2021
@todo todo bot assigned pan-apple Jul 29, 2021
woody-apple pushed a commit that referenced this issue Oct 21, 2021
…ING (#10745)

* Fix various OCTET_STRING bits that should be CHAR_STRING.

Fixes #5542
Fixes #6112
Fixes #7112
Fixes #7322
Fixes #7654
Fixes #7655
Fixes #8704
Fixes #8705
Fixes #8706
Fixes #8707
Fixes #9797
Fixes #9798
Fixes #10508
Fixes #10509

* Regenerate generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant