Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chip-tool should randomize the node ids it assigns #8439

Closed
bzbarsky-apple opened this issue Jul 15, 2021 · 1 comment · Fixed by #8450
Closed

chip-tool should randomize the node ids it assigns #8439

bzbarsky-apple opened this issue Jul 15, 2021 · 1 comment · Fixed by #8450
Assignees
@bzbarsky-apple

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

chip-tool uses the same node id every time, which can cause problems due to multiple entities being commissioned with the same node id

Proposed Solution

Randomize node ids in chip-tool during pairing.
@bzbarsky-apple bzbarsky-apple self-assigned this Jul 15, 2021
@bzbarsky-apple
Copy link
Contributor Author

I guess right now the node id is not stored anywhere, just hardcoded....

I guess we could store it in the persistent storage, and reset for the pairing commands? @vivien-apple

@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 16, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 16, 2021
@bzbarsky-apple
Have chip-tool generate a random remote node id every time it pairs.
8364d6a 
This way multiple things we pair don't step on each other's toes as
far as mdns advertisements go.

Fixes project-chip#8439
woody-apple pushed a commit that referenced this issue Jul 16, 2021
@bzbarsky-apple
Have chip-tool generate a random remote node id every time it pairs. (#…
1571f74 
…8450)

This way multiple things we pair don't step on each other's toes as
far as mdns advertisements go.

Fixes #8439
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this issue Sep 23, 2021
@bzbarsky-apple
Have chip-tool generate a random remote node id every time it pairs. (p…
dd59744 
…roject-chip#8450)

This way multiple things we pair don't step on each other's toes as
far as mdns advertisements go.

Fixes project-chip#8439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have chip-tool generate a random remote node id every time it pairs. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple