Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#5556): Convert MDNS to WatchableSocket. #7758

Closed
todo bot opened this issue Jun 18, 2021 · 0 comments · Fixed by #7799
Closed

(#5556): Convert MDNS to WatchableSocket. #7758

todo bot opened this issue Jun 18, 2021 · 0 comments · Fixed by #7799
Assignees
@kpschoedel
Labels
todo

Comments

@todo
Copy link

todo bot commented Jun 18, 2021

connectedhomeip/src/system/WatchableSocketLibevent.cpp

Lines 28 to 38 in c4468cf

// TODO(#5556): Convert MDNS to WatchableSocket.
#error "POSIX platform with MDNS currently must use select()"
#endif // CHIP_DEVICE_CONFIG_ENABLE_MDNS
#ifndef CHIP_CONFIG_LIBEVENT_DEBUG_CHECKS
#define CHIP_CONFIG_LIBEVENT_DEBUG_CHECKS 1 // TODO(#5556): default to off
#endif
namespace chip {
namespace System {

This issue was generated by todo based on a TODO comment in c4468cf when #6561 was merged. cc @kpschoedel.
@todo todo bot added the todo label Jun 18, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Jun 21, 2021
@kpschoedel
#### Problem
71beccb 
Followups from project-chip#6561 Generalize socket-based event loop

#### Change overview

* mDNS: Convert `platform/Linux/MdnsImpl`; remove Darwin stubs.
* Change `mCallbackData` type to `intptr_t` (review feedback).
* Comment for `System::WakeEvent` (this is minimal since it's
  likely to change soon for issue project-chip#7725).

Fixes project-chip#7758 _Convert MDNS to WatchableSocket._

#### Testing

Manual sanity check of mDNS using chip-device-ctrl on Linux.
Otherwise, no change to functionality is intended.
@kpschoedel kpschoedel mentioned this issue Jun 21, 2021
Merged
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Jun 22, 2021
@kpschoedel
#### Problem
bc0f8d2 
Followups from project-chip#6561 Generalize socket-based event loop

#### Change overview

* mDNS: Convert `platform/Linux/MdnsImpl`; remove Darwin stubs.
* Change `mCallbackData` type to `intptr_t` (review feedback).
* Comment for `System::WakeEvent` (this is minimal since it's
  likely to change soon for issue project-chip#7725).

Fixes project-chip#7758 _Convert MDNS to WatchableSocket._

#### Testing

Manual sanity check of mDNS using chip-device-ctrl on Linux.
Otherwise, no change to functionality is intended.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Jun 22, 2021
@kpschoedel
#### Problem
9d1fc1e 
Followups from project-chip#6561 Generalize socket-based event loop

#### Change overview

* mDNS: Convert `platform/Linux/MdnsImpl`; remove Darwin stubs.
* Change `mCallbackData` type to `intptr_t` (review feedback).
* Comment for `System::WakeEvent` (this is minimal since it's
  likely to change soon for issue project-chip#7725).

Fixes project-chip#7758 _Convert MDNS to WatchableSocket._

#### Testing

Manual sanity check of mDNS using chip-device-ctrl on Linux.
Otherwise, no change to functionality is intended.
andy31415 pushed a commit that referenced this issue Jun 23, 2021
@kpschoedel
Followups from #6561 Generalize socket-based event loop (#7799)
9692e9a 
* #### Problem

Followups from #6561 Generalize socket-based event loop

#### Change overview

* mDNS: Convert `platform/Linux/MdnsImpl`; remove Darwin stubs.
* Change `mCallbackData` type to `intptr_t` (review feedback).
* Comment for `System::WakeEvent` (this is minimal since it's
  likely to change soon for issue #7725).

Fixes #7758 _Convert MDNS to WatchableSocket._

#### Testing

Manual sanity check of mDNS using chip-device-ctrl on Linux.
Otherwise, no change to functionality is intended.

* review

* review
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this issue Sep 23, 2021
@kpschoedel
Followups from project-chip#6561 Generalize socket-based event loop (p…
f96b622 
…roject-chip#7799)

* #### Problem

Followups from project-chip#6561 Generalize socket-based event loop

#### Change overview

* mDNS: Convert `platform/Linux/MdnsImpl`; remove Darwin stubs.
* Change `mCallbackData` type to `intptr_t` (review feedback).
* Comment for `System::WakeEvent` (this is minimal since it's
  likely to change soon for issue project-chip#7725).

Fixes project-chip#7758 _Convert MDNS to WatchableSocket._

#### Testing

Manual sanity check of mDNS using chip-device-ctrl on Linux.
Otherwise, no change to functionality is intended.

* review

* review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpschoedel kpschoedel

Labels
todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Followups from #6561 Generalize socket-based event loop kpschoedel/connectedhomeip
1 participant
@kpschoedel