Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove this work around due to crashes when storage is accessed from multiple th... #7410

Closed
todo bot opened this issue Jun 4, 2021 · 0 comments · Fixed by #7434
Closed

Remove this work around due to crashes when storage is accessed from multiple th... #7410

todo bot opened this issue Jun 4, 2021 · 0 comments · Fixed by #7434
Assignees
@woody-apple
Labels
todo

Comments

@todo
Copy link

todo bot commented Jun 4, 2021

connectedhomeip/examples/chip-tool/commands/common/Commands.cpp

Lines 41 to 48 in 8402293

// TODO: Remove this work around due to crashes when storage is accessed from multiple threads and passed around
static PersistentStorage gStorage;
int Commands::Run(NodeId localId, NodeId remoteId, int argc, char ** argv)
{
CHIP_ERROR err = CHIP_NO_ERROR;
err = chip::Platform::MemoryInit();
VerifyOrExit(err == CHIP_NO_ERROR, ChipLogError(Controller, "Init Memory failure: %s", chip::ErrorStr(err)));

This issue was generated by todo based on a TODO comment in 8402293. It's been assigned to @woody-apple because they committed the code.
@todo todo bot added the todo label Jun 4, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 7, 2021
@bzbarsky-apple
Remove workarounds for threading problems from chip-tool commands.
2a385a6 
This change depends on
project-chip#7428 and
project-chip#7430 which fix
the problems properly.

Fixes project-chip#7408
Fixes project-chip#7409
Fixes project-chip#7410
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 7, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 8, 2021
@bzbarsky-apple
Remove workarounds for threading problems from chip-tool commands.
7b039d7 
This change depends on
project-chip#7428 and
project-chip#7430 which fix
the problems properly.

Fixes project-chip#7408
Fixes project-chip#7409
Fixes project-chip#7410
bzbarsky-apple added a commit that referenced this issue Jun 9, 2021
@bzbarsky-apple
Remove workarounds for threading problems from chip-tool commands. (#…
17adc8c 
…7434)

This change depends on
#7428 and
#7430 which fix
the problems properly.

Fixes #7408
Fixes #7409
Fixes #7410
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this issue Sep 23, 2021
@bzbarsky-apple
Remove workarounds for threading problems from chip-tool commands. (p…
3b8c89f 
…roject-chip#7434)

This change depends on
project-chip#7428 and
project-chip#7430 which fix
the problems properly.

Fixes project-chip#7408
Fixes project-chip#7409
Fixes project-chip#7410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woody-apple woody-apple

Labels
todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove workarounds for threading problems from chip-tool commands. bzbarsky-apple/connectedhomeip
1 participant
@woody-apple