Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGENDIAN_CPU is not defined in the build system for big-endian builds #7281

Closed
jrhees-cae opened this issue Jun 1, 2021 · 6 comments · Fixed by #29294
Closed

BIGENDIAN_CPU is not defined in the build system for big-endian builds #7281

jrhees-cae opened this issue Jun 1, 2021 · 6 comments · Fixed by #29294
Assignees
@bzbarsky-apple
Labels
bug Something isn't working build issue future

Comments

@jrhees-cae
Copy link
Contributor

Problem

The zcl code in CHIP relies on the BIGENDIAN_CPU define to affect endianness behavior. However, BIGENDIAN_CPU is not defined by default on gnu compilers for bigendian targets.

Proposed Solution

Possible solutions:

  1. Change the references to BIGENDIAN_CPU in the zcl code and zap templates to more universal endian identifier
  2. Add a global define for BIGNEDIAN_CPU to the root BUILD.gn
@gerickson
Copy link
Contributor

Would definitely vote for the ZCL/ZAP code to use the same constructs found in the underlying CHIP/Matter nlio package.

@bzbarsky-apple
Copy link
Contributor

@mspang What's the best option here? I'm happy to change the ZCL code to use whatever define is most convenient....

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 31, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 10, 2022
@franck-apple franck-apple added the p1 priority 1 work label Oct 24, 2022
@woody-apple woody-apple added future and removed p1 priority 1 work V1.0 labels Nov 2, 2022
@woody-apple
Copy link
Contributor

Issue Scrub: Keeping this open, however needs someone to champion this work, moving to Future.

@stale
Copy link

stale bot commented May 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label May 2, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label May 3, 2023
@woody-apple woody-apple added the bug Something isn't working label Jun 24, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2023
Open
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 15, 2023
@bzbarsky-apple
Ensure we always have our endianness defined.
8ce9d1f 
And easily configurable in the build.

Fixes project-chip#7281
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 15, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 15, 2023
@bzbarsky-apple
Ensure we always have our endianness defined.
b5f5f04 
And easily configurable in the build.

Fixes project-chip#7281
@mergify mergify bot closed this as completed in #29294 Sep 18, 2023
mergify bot pushed a commit that referenced this issue Sep 18, 2023
@bzbarsky-apple
Ensure we always have our endianness defined. (#29294)
394eed3 
* Ensure we always have our endianness defined.

And easily configurable in the build.

Fixes #7281

* Address review comment.
@github-project-automation github-project-automation bot moved this from Todo to Done in [Build] Build Issues Sep 18, 2023
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Ensure we always have our endianness defined. (project-chip#29294)
f4e52af 
* Ensure we always have our endianness defined.

And easily configurable in the build.

Fixes project-chip#7281

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
bug Something isn't working build issue future
Projects
[Build] Build Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we always have our endianness defined. bzbarsky-apple/connectedhomeip
8 participants
@mspang @gerickson @andy31415 @woody-apple @jrhees-cae @bzbarsky-apple @kpschoedel @franck-apple