Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChipDeviceController uses 32-bit integer representation for device ID instead of 64-bit long value #5630

Closed
g-coppock opened this issue Mar 25, 2021 · 0 comments · Fixed by #5709
Closed

ChipDeviceController uses 32-bit integer representation for device ID instead of 64-bit long value #5630

g-coppock opened this issue Mar 25, 2021 · 0 comments · Fixed by #5709
Assignees
@austinh0
Labels
android

Comments

@g-coppock
Copy link
Contributor

g-coppock commented Mar 25, 2021 •
edited
Loading

Problem

In ChipDeviceController.java, the deviceId parameters (for example, in pairDevice or unpairDevice) are represented by int types (which are 32-bit). CHIP device IDs are 64-bit, so should be represented by a long instead.

Proposed Solution

Amend ChipDeviceController.java and CHIPDeviceController-JNI.cpp to use long and jlong, respectively, to support 64-bit device IDs.
@austinh0 austinh0 self-assigned this Mar 29, 2021
g-coppock added a commit to g-coppock/connectedhomeip that referenced this issue Mar 31, 2021
@g-coppock
Use 64-bit long type for Java layer device IDs (project-chip#5630)
e56e2a0 
Tested by pairing an m5stack using a hardcoded ID of FFEE00124444AAAA.
@g-coppock g-coppock mentioned this issue Mar 31, 2021
Merged
andy31415 pushed a commit that referenced this issue Mar 31, 2021
@g-coppock
Use 64-bit long type for Java layer device IDs (#5630) (#5709)
1e254c9 
Tested by pairing an m5stack using a hardcoded ID of FFEE00124444AAAA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinh0 austinh0

Labels
android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 64-bit long type for Java layer device IDs (#5630) g-coppock/connectedhomeip
2 participants
@g-coppock @austinh0