We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
So.. this is completely unsafe. It will do weird and broken things if the value in the TLV is out of range for type T.
Originally posted by @bzbarsky-apple in #3491 (comment)
The text was updated successfully, but these errors were encountered:
Referencing this code:
[src/app/MessageDef.cpp]
VerifyOrExit(aTLVType == reader.GetType(), err = CHIP_ERROR_WRONG_TLV_TYPE); err = reader.Get(*apLValue);
But that file has since been significantly refactored into an entire directory: src/app/MessageDef.
src/app/MessageDef
Difficult to say whether the issue still exists, but need to follow-up and verify for v1.
Removing v1_triage_split_4 tag.
v1_triage_split_4
Sorry, something went wrong.
The important part is that we fixed Get on the reader to not do broken things in #9944. So this is good now.
Get
yunhanw-google
No branches or pull requests
So.. this is completely unsafe. It will do weird and broken things if the value in the TLV is out of range for type T.
Originally posted by @bzbarsky-apple in #3491 (comment)
The text was updated successfully, but these errors were encountered: