Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] may save more flash by splitting list iterator templates even more #36264

Closed
andy31415 opened this issue Oct 28, 2024 · 0 comments · Fixed by #36279
Closed

[feature] may save more flash by splitting list iterator templates even more #36264

andy31415 opened this issue Oct 28, 2024 · 0 comments · Fixed by #36279

Comments

@andy31415
Copy link
Contributor

#36253 saves some flash, however we could try for more by not allowing even iterator code to duplicate itself so much:

see #36253 (comment) and #36253 (comment) generally saying that parts of DecodableList::Iterator could be split out and we could also make the isFabricSensitive to be somehow only duplicating the template twice instead for every type.
@andy31415 andy31415 mentioned this issue Oct 28, 2024
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 29, 2024
@bzbarsky-apple
Factor out common parts of list iterators into shared super-classes.
a002b5f 
Saves some codesize.

Fixes project-chip#36264
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 29, 2024
Merged
woody-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 29, 2024
@bzbarsky-apple @woody-apple
Factor out common parts of list iterators into shared super-classes.
b3c9305 
Saves some codesize.

Fixes project-chip#36264
@mergify mergify bot closed this as completed in #36279 Oct 29, 2024
mergify bot pushed a commit that referenced this issue Oct 29, 2024
@bzbarsky-apple
Factor out common parts of list iterators into shared super-classes. (#…
8211b69 
…36279)

* Factor out common parts of list iterators into shared super-classes.

Saves some codesize.

Fixes #36264

* Remove unused variables.
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this issue Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Factor out common parts of list iterators into shared super-classes. (p…
011b171 
…roject-chip#36279)

* Factor out common parts of list iterators into shared super-classes.

Saves some codesize.

Fixes project-chip#36264

* Remove unused variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Factor out common parts of list iterators into shared super-classes. bzbarsky-apple/connectedhomeip
1 participant
@andy31415