Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/python_testing/TC_TSTAT_4_2.py should use symbolic names for the requestType constants passed to AtomicRequest #34742

Closed
bzbarsky-apple opened this issue Aug 2, 2024 · 0 comments · Fixed by #34824
Closed

src/python_testing/TC_TSTAT_4_2.py should use symbolic names for the requestType constants passed to AtomicRequest #34742

bzbarsky-apple opened this issue Aug 2, 2024 · 0 comments · Fixed by #34824
Assignees
@hasty
Labels
build issue needs triage tests thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues

Comments

@bzbarsky-apple
Copy link
Contributor

Test issue(s)

See #34570 (comment). Right now the test uses bare 0, 1, etc for these enum values.

Platform

core (please add to version below)

Anything else?

No response
@bzbarsky-apple bzbarsky-apple changed the title src/python_testing/TC_TSTAT_4_2.py should use symbolic named for the requestType constants passed to AtomicRequest src/python_testing/TC_TSTAT_4_2.py should use symbolic names for the requestType constants passed to AtomicRequest Aug 2, 2024
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 2, 2024
Merged
@hasty hasty self-assigned this Aug 6, 2024
@hasty hasty mentioned this issue Aug 6, 2024
Merged
@mergify mergify bot closed this as completed in #34824 Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [Build] Build Issues Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasty hasty

Labels
build issue needs triage tests thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues
Projects
[Build] Build Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HVAC] Use Globals.Enums.AtomicRequestTypeEnum in TC_TSTAT_4_2 hasty/connectedhomeip
2 participants
@hasty @bzbarsky-apple