Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceArea: constructors with many args + assignment operator not making identical copy #34519

Closed
2 tasks
plauric opened this issue Jul 25, 2024 · 1 comment · Fixed by #34814
Closed
2 tasks
Assignees

Comments

@plauric
Copy link
Contributor

plauric commented Jul 25, 2024

Requesting changes: I would want some comments to actually be addressed instead of being argued as do not actually need to change (or if the argument of not changing is good, I would like to make sure I review the reply). After seeing the answers, I believe we need at least:

  • use builders for arguments when the argument count starts being large (usually after around 4-5 arguments ... and always if there are same-type arguments especially bools or nullable things)
  • do not use operator= to mean anything else than "exact copy"

Originally posted by @andy31415 in #33991 (review)

@andy31415
Copy link
Contributor

As an offline discussion, it was discussed to make these as a separate PR instead of in #33991. I am ok with that as long as there is commitment for the followup to happen soon. Because historically we had a very low rate of actual promised followups, I would like to have a commitment that one of 2 things happen:

  • followup PR(s) fix the above (great!)
  • followups do not happen in 2-3 weeks, in which case Implementation of service area server #33991 and any followups on it would get rolled back (this should really not happen ... just having this as a guarantee that the followups have high priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants