Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] sleeps for 500ms every transaction when using NimBLE #3400

Closed
mspang opened this issue Oct 22, 2020 · 2 comments · Fixed by #3402
Closed

[ESP32] sleeps for 500ms every transaction when using NimBLE #3400

mspang opened this issue Oct 22, 2020 · 2 comments · Fixed by #3402
Assignees
@mspang
Labels
bug Something isn't working

Comments

@mspang
Copy link
Contributor

mspang commented Oct 22, 2020

https://github.com/project-chip/connectedhomeip/blob/master/src/platform/ESP32/nimble/BLEManagerImpl.cpp#L408-L411

This continues delaying even after "NimBLE host task" is up and running and adds up to quite a lot of delay over time.

@prasad-alatkar
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.61. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 22, 2020
@mspang
Copy link
Contributor Author

mspang commented Oct 22, 2020

This is a regression in the NimBLE integration that's not present in the Bluedroid integration.

@mspang mspang self-assigned this Oct 22, 2020
mspang added a commit to mspang/connectedhomeip that referenced this issue Oct 22, 2020
@mspang
[ESP32] Make the 500ms sleep only happen once with NimBLE
bec3791 
There's a 500ms sleep in DriveBLEState when using NimBLE. Make it only
happen once during initialization.

It still seems wrong, at least it's less wrong and the whole
rendezvous flow is now 3x faster (~15s -> ~5s).

Fixes project-chip#3400
mspang added a commit to mspang/connectedhomeip that referenced this issue Oct 22, 2020
@mspang
[ESP32] Make the 500ms sleep only happen once with NimBLE
88badd2 
There's a 500ms sleep in DriveBLEState when using NimBLE. Make it only
happen once during initialization.

It still seems wrong, at least it's less wrong and the whole
rendezvous flow is now 3x faster (~15s -> ~5s).

Fixes project-chip#3400
@mspang mspang mentioned this issue Oct 22, 2020
Merged
mspang added a commit to mspang/connectedhomeip that referenced this issue Oct 22, 2020
@mspang
[ESP32] Make the 500ms sleep only happen once with NimBLE
68710b1 
There's a 500ms sleep in DriveBLEState when using NimBLE. Make it only
happen once during initialization.

It still seems wrong, at least it's less wrong and the whole
rendezvous flow is now 3x faster (~15s -> ~5s).

Fixes project-chip#3400
andy31415 pushed a commit that referenced this issue Oct 23, 2020
@mspang
[ESP32] Make the 500ms sleep only happen once with NimBLE (#3402)
814ef41 
There's a 500ms sleep in DriveBLEState when using NimBLE. Make it only
happen once during initialization.

It still seems wrong, at least it's less wrong and the whole
rendezvous flow is now 3x faster (~15s -> ~5s).

Fixes #3400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mspang mspang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ESP32] Make the 500ms sleep only happen once with NimBLE mspang/connectedhomeip
1 participant
@mspang