Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sending an AddNOC with an invalid ACL subject causes the failsafe to be disarmed #30799

Closed
cecille opened this issue Dec 4, 2023 · 1 comment
Assignees
Labels
bug Something isn't working needs triage

Comments

@cecille
Copy link
Contributor

cecille commented Dec 4, 2023

Reproduction steps

Spec reference from 11.17.6.8 Effect on receipt:

If the CaseAdminSubject field is not a valid ACL subject in the context of AuthMode set to CASE, such as not being in either the Operational or CASE Authenticated Tag range, then the device SHALL process the error by responding with a StatusCode of InvalidAdminSubject as described in Section 11.17.6.7.2, “Handling Errors”.

The spec doesn't say the failsafe is disarmed as a response to any of these errors, so I think this is just an ordering problem in the SDK.

Bug prevalence

always

GitHub hash of the SDK that was being used

28c679c

Platform

core

Platform Version(s)

No response

Anything else?

No response

@cecille cecille added bug Something isn't working needs triage labels Dec 4, 2023
@cecille cecille self-assigned this Dec 4, 2023
cecille added a commit to cecille/connectedhomeip that referenced this issue Dec 5, 2023
Moving this check to before the fabric gets added so that the
changes do not have to be backed out if this is invalid.

see project-chip#30799

This will be checked in TC-OPCREDS-3.1 (under development)
mergify bot pushed a commit that referenced this issue Dec 6, 2023
Moving this check to before the fabric gets added so that the
changes do not have to be backed out if this is invalid.

see #30799

This will be checked in TC-OPCREDS-3.1 (under development)
@cecille
Copy link
Contributor Author

cecille commented Dec 13, 2023

Linked PR addressed this issue.

@cecille cecille closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant