Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Matter 1.3 TCR] Need to add plumbing for SupportedWiFiBands for Network Commissioning #30107

Closed
tcarmelveilleux opened this issue Oct 30, 2023 · 0 comments · Fixed by #31349
Closed

[Matter 1.3 TCR] Need to add plumbing for SupportedWiFiBands for Network Commissioning #30107

tcarmelveilleux opened this issue Oct 30, 2023 · 0 comments · Fixed by #31349
Assignees
@tcarmelveilleux
Labels
commissioning Involves placing devices on the network, initial setup TCR
Milestone
1.3 Feature Complete

Comments

@tcarmelveilleux
Copy link
Contributor

tcarmelveilleux commented Oct 30, 2023 •
edited
Loading

Reporting supported bands is required in Matter 1.3.

Support must be added to src/include/platform/NetworkCommissioning.h and associated files to report the supported bands enum properly.

See https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7571 for the spec side.
@tcarmelveilleux tcarmelveilleux added commissioning Involves placing devices on the network, initial setup TCR labels Oct 30, 2023
@tcarmelveilleux tcarmelveilleux added this to the 1.3 Feature Complete milestone Oct 30, 2023
@tcarmelveilleux tcarmelveilleux self-assigned this Oct 30, 2023
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 10, 2024
@tcarmelveilleux
Make supported Wi-Fi bands API less error prone
2345d71 
- Return a bitmask rather than mutating a span which could have led
  to misuse.
- Make Network Commissioning cluster revision programmatic
  to avoid rev 1 leftovers (illegal starting at 1.3).
- Fix an internal error case on writes.

Fixes project-chip#30107
Issue project-chip#30110

Testing done:
- Existing integration tests still pass with refactor.
@tcarmelveilleux tcarmelveilleux mentioned this issue Jan 10, 2024
Merged
mergify bot pushed a commit that referenced this issue Jan 15, 2024
@tcarmelveilleux @restyled-commits @tennessee-google
Make supported Wi-Fi bands API less error prone (#31349)
7ef397e 
* Make supported Wi-Fi bands API less error prone

- Return a bitmask rather than mutating a span which could have led
  to misuse.
- Make Network Commissioning cluster revision programmatic
  to avoid rev 1 leftovers (illegal starting at 1.3).
- Fix an internal error case on writes.

Fixes #30107
Issue #30110

Testing done:
- Existing integration tests still pass with refactor.

* Restyled by clang-format

* Fix CI

* Address review comments

* Fix CI

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: [email protected] <[email protected]>
@mergify mergify bot closed this as completed in #31349 Jan 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [TCR] 1.3 TCRs Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
commissioning Involves placing devices on the network, initial setup TCR
Projects
[1.3] SDK Feature Complete
Archived in project
[TCR] 1.3 TCRs
Archived in project
Milestone
1.3 Feature Complete
Development

Successfully merging a pull request may close this issue.

Make supported Wi-Fi bands API less error prone tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux