Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Untangle Span.h #29490

Closed
cecille opened this issue Sep 28, 2023 · 0 comments · Fixed by #29491
Closed

[Build] Untangle Span.h #29490

cecille opened this issue Sep 28, 2023 · 0 comments · Fixed by #29491
Labels
build issue darwin needs triage

Comments

@cecille
Copy link
Contributor

cecille commented Sep 28, 2023

Build issue(s)

Right now Span.h isn't included in the support library. This appears to be on purpose as there are some strange dependencies that cause problems with the darwin logging library. We could potentially pull it out into its own source set with proper dependencies, which would make adding span a lot easier because right now you have to add the config, nlassert and optionally the pigweed tokenizer to get span support. This should be bundled. But it also then requires that the code utils be pulled out into their own set.

Platform

all

Anything else?

No response
@cecille cecille mentioned this issue Sep 28, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 28, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
365c125 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".  Maybe these should just all be lumped into "support_core"... but
then why are these things in support/ and not core/ (which are very much "these
are the same thing, but we are going to pretend the are not).

Fixes project-chip#29490
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 28, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 9, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
e9915b4 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".  Maybe these should just all be lumped into "support_core"... but
then why are these things in support/ and not core/ (which are very much "these
are the same thing, but we are going to pretend the are not).

Fixes project-chip#29490
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 12, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
7e30c5b 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes project-chip#29490
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 12, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
98c9c7d 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes project-chip#29490
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 12, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
74dc8e8 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes project-chip#29490
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 12, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies.
2e61d80 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes project-chip#29490
@mergify mergify bot closed this as completed in #29491 Oct 13, 2023
mergify bot pushed a commit that referenced this issue Oct 13, 2023
@bzbarsky-apple
Add Span.h to a source_set that tracks its dependencies. (#29491)
d1b59df 
This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes #29490
@github-project-automation github-project-automation bot moved this from Todo to Done in [Build] Build Issues Oct 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Oct 13, 2023
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Add Span.h to a source_set that tracks its dependencies. (project-chi…
41ed003 
…p#29491)

This requires that those dependencies be separate things that are not the entire
"support" library, because some things need Span but can't depend on all of
"support".

Fixes project-chip#29490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issue darwin needs triage
Projects
[Build] Build Issues
Archived in project
[Platform] Darwin
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Span.h to a source_set that tracks its dependencies. bzbarsky-apple/connectedhomeip
1 participant
@cecille