Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all .zap files #28967

Closed
brdandu opened this issue Aug 30, 2023 · 0 comments · Fixed by #28988
Closed

Update all .zap files #28967

brdandu opened this issue Aug 30, 2023 · 0 comments · Fixed by #28988
Labels
bug Something isn't working needs triage

Comments

@brdandu
Copy link
Contributor

brdandu commented Aug 30, 2023 •
edited
Loading

Reproduction steps

.zap files will see removal of device type ids when opened and saved again. They will also see a deterministic id for endpoint types ids. This should happen only once. The subsequent saves to .zap files should not run into this issue.

This is related to https://csamembers.slack.com/archives/C01B01GH64E/p1693019555053839 and the fix has been placed in project-chip/zap#1117

Also update to ZAP build v2023.08.30-nightly or later for the fix

Bug prevalence

The first time they open a .zap file and save it again.

GitHub hash of the SDK that was being used

79292ad

Platform

other

Platform Version(s)

No response

Anything else?

No response
@brdandu brdandu added bug Something isn't working needs triage labels Aug 30, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 31, 2023
@bzbarsky-apple
Update ZAP to v2023.08.30-nightly.
9d7d2f0 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes project-chip#28967
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 31, 2023
@bzbarsky-apple
Update ZAP to v2023.08.30-nightly.
412fb2a 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes project-chip#28967
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 31, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 1, 2023
@bzbarsky-apple
Update ZAP to v2023.08.30-nightly.
778efd0 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes project-chip#28967
@mergify mergify bot closed this as completed in #28988 Sep 1, 2023
mergify bot pushed a commit that referenced this issue Sep 1, 2023
@bzbarsky-apple
Update ZAP to v2023.08.30-nightly. (#28988)
32bd913 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes #28967
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
@bzbarsky-apple @abpoth
Update ZAP to v2023.08.30-nightly. (project-chip#28988)
3a59a83 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes project-chip#28967
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Update ZAP to v2023.08.30-nightly. (project-chip#28988)
99f966c 
This fixes non-determinism in .zap files, so they will stop changing every time
they are opened/closed.

Fixes project-chip#28967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ZAP to v2023.08.30-nightly. bzbarsky-apple/connectedhomeip
1 participant
@brdandu