Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPSTATE] specific phase in the list should not null #27931

Closed
mideayanghui opened this issue Jul 13, 2023 · 1 comment · Fixed by #31176
Closed

[OPSTATE] specific phase in the list should not null #27931

mideayanghui opened this issue Jul 13, 2023 · 1 comment · Fixed by #31176
Assignees
@mideayanghui
Labels
operational state
Milestone
1.3 Release

Comments

@mideayanghui
Copy link
Contributor 

          The cited code is not about PhaseList, though.  It's about a specific phase _in the list_.  Those can never be null.

Originally posted by @bzbarsky-apple in #26971 (comment)
@mideayanghui mideayanghui mentioned this issue Jul 13, 2023
Merged
@mideayanghui
Copy link
Contributor Author

mideayanghui commented Jul 13, 2023 •
edited
Loading

Besides, need optimize the use GetOperationalPhaseAtIndex in lambda function. And move the pieces that tmp variable associtated into the lambda function.

@hicklin hicklin mentioned this issue Sep 11, 2023
Merged
@woody-apple woody-apple added this to the 1.3 Release milestone Oct 31, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Dec 22, 2023
Merged
mideayanghui added a commit to mideayanghui/connectedhomeip that referenced this issue Dec 22, 2023
@mideayanghui
fix project-chip#27931 [OPSTATE] specific phase in the list should no…
db93e5c 
…t null
@mideayanghui mideayanghui mentioned this issue Dec 22, 2023
Merged
yunhanw-google pushed a commit that referenced this issue Jan 9, 2024
@mideayanghui @restyled-commits
Fixes: [OPSTATE] specific phase in the list should not null (#31176)
e241e32 
* fix #27931 [OPSTATE] specific phase in the list should not null

* Restyled by clang-format

* remove unuseful namespace

* modify the document of api

* modify the document for api

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mideayanghui mideayanghui

Labels
operational state
Projects
[Feature] Operational State
Archived in project
Milestone
1.3 Release
Development

Successfully merging a pull request may close this issue.

Fixes: [OPSTATE] specific phase in the list should not null mideayanghui/connectedhomeip
3 participants
@woody-apple @bzbarsky-apple @mideayanghui