Extend the BufferReader and BufferWriter to handle signed integers #27629
Assignees
Labels
Comments
tcarmelveilleux
changed the title
tcarmelveilleux
pushed a commit
to tcarmelveilleux/connectedhomeip
that referenced
this issue
Jul 5, 2023
Problem: - Safe buffer reader/writer doesn't support signed values - Safe buffer reader/writer doesn't support bools - Fixes project-chip#27629 This PR: - Adds signed and bool support to BufferWriter and to Reader - Adds missing unit tests - Makes it clear that low-level reads are not to be used directly Testing done: - Integration tests pass - New unit tests added and pass - Existing unit tests all pass
mergify bot
pushed a commit
that referenced
this issue
Jul 6, 2023
* Add support for signed/bool to BufferReader/Writer Problem: - Safe buffer reader/writer doesn't support signed values - Safe buffer reader/writer doesn't support bools - Fixes #27629 This PR: - Adds signed and bool support to BufferWriter and to Reader - Adds missing unit tests - Makes it clear that low-level reads are not to be used directly Testing done: - Integration tests pass - New unit tests added and pass - Existing unit tests all pass * Restyled by clang-format --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature description
The
BufferReaderandBufferWriterclasses in/src/lib/supportdo not currently support the reading and writing of signed integers.Add reading and writhing of
in8_t,int16_t,intu32_tandint64_t.Platform
all
Platform Version(s)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: