Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Darwin build failure #27438

Closed
woody-apple opened this issue Jun 23, 2023 · 2 comments · Fixed by #27443
Closed

[Build] Darwin build failure #27438

woody-apple opened this issue Jun 23, 2023 · 2 comments · Fixed by #27443
Assignees
@bzbarsky-apple @vivien-apple
Labels
bug Something isn't working build issue darwin
Milestone
1.2

Comments

@woody-apple
Copy link
Contributor

Build issue(s)

https://github.com/project-chip/connectedhomeip/actions/runs/5355597420/jobs/9714067297

Looks different than current ones.

Platform

darwin

Anything else?

No response
@woody-apple woody-apple added this to the 1.2 milestone Jun 23, 2023
@woody-apple woody-apple moved this to In Progress in [Platform] Darwin Jun 23, 2023
@woody-apple woody-apple moved this from In Progress to Todo in [Platform] Darwin Jun 23, 2023
@bzbarsky-apple
Copy link
Contributor

The actual failure part of the log:

2023-06-23T11:52:03.9354410Z [1687521112101] [88373:222780] [DMG] Refresh LivenessCheckTime for 5224 milliseconds with SubscriptionId = 0xf507724e Peer = 02:0000000011223344
...

2023-06-23T11:52:03.9361730Z src/controller/tests/data_model/TestRead.cpp:1804: assertion failed: "callback.mOnError == 1"
2023-06-23T11:52:03.9361940Z src/controller/tests/data_model/TestRead.cpp:1805: assertion failed: "callback.mLastError == CHIP_ERROR_TIMEOUT"
2023-06-23T11:52:03.9362120Z src/controller/tests/data_model/TestRead.cpp:1806: assertion failed: "callback.mOnDone == 1"
2023-06-23T11:52:03.9362430Z '#3:','TestSubscribeAttributeTimeout                             ','FAILED'
2023-06-23T11:52:03.9362990Z [1687521117392] [88373:222780] [EM] <<< [E:12940i S:2 M:204948763] (S) Msg TX to 1:0000000012344321 [6EF6] --- Type 0001:03 (IM:SubscribeRequest)

Sadly, the failure bits don't come with Matter timestamps, just the harness timestamp, and that's much later than the Mater bits, afaict.

But 1687521117392 - 1687521112101 == 5291, so it does look like we took longer than 5224ms to get to that next step... but it's still possible our timer here raced the liveness check timer. We are currently adding 50ms in ComputeSubscriptionTimeout, but maybe we need to add more to avoid races....

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 23, 2023
@bzbarsky-apple
Increase the timer slack TestRead allows to 100ms.
6679020 
We're polling until a timer fires, but due to other threads losing the timeslice
for a while we could decide it's not firing when it's just been blocked on the
scheduler.  To reduce the risk of that, give it a bit more time to fire.

Fixes project-chip#27438
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 23, 2023
Merged
@woody-apple
Copy link
Contributor Author

Another one here: https://github.com/project-chip/connectedhomeip/actions/runs/5360350319/jobs/9725105030

@woody-apple woody-apple moved this from Todo to In Progress in [Platform] Darwin Jun 23, 2023
@mergify mergify bot closed this as completed in #27443 Jun 23, 2023
mergify bot pushed a commit that referenced this issue Jun 23, 2023
@bzbarsky-apple
Increase the timer slack TestRead allows to 100ms. (#27443)
f467d6f 
We're polling until a timer fires, but due to other threads losing the timeslice
for a while we could decide it's not firing when it's just been blocked on the
scheduler.  To reduce the risk of that, give it a bit more time to fire.

Fixes #27438
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Platform] Darwin Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

@vivien-apple vivien-apple

Labels
bug Something isn't working build issue darwin
Projects
[Platform] Darwin
Archived in project
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Increase the timer slack TestRead allows to 100ms. bzbarsky-apple/connectedhomeip
3 participants
@woody-apple @bzbarsky-apple @vivien-apple