Mode Select - renamed RVC cluster aliases #26551
Assignees
Labels
cert blocker
Spec XML align
SDK XML does not match the spec (including naming, etc)
spec
Mismatch between spec and implementation
v1.2
Comments
bzbarsky-apple
added
spec
hicklin
added a commit
to dysonltd/connectedhomeip
that referenced
this issue
May 22, 2023
|
Fixed here. |
bzbarsky-apple
added a commit
that referenced
this issue
Jun 5, 2023
* Updated the mode select xml to match the current spec. * Added the version bump to the mode select cluster as per PR comment. * Fixed new command xml definitions missing the response and disableDefaultResponse specifiers. * Renamed the mode select feature map fields to match the general behavior. * Added data-model XML definitions for all Mode Select aliased clusters. * Added the Mode Select alias clusters' XMLs to the relevant lists. * Updated the controller zap file to include the new clusters. * Fixed errors in the Mode Select alias' XML feature maps. * Added generated code * Restyled by prettier-json * Simplified the Mode Select cluster XMLs. * Matched the ModeSelect alias clusters' version to the ModeSelect cluster. * Update src/app/zap-templates/zcl/data-model/chip/mode-select-cluster.xml Co-authored-by: Boris Zbarsky <[email protected]> * Removed white spaces in ChangeToModeResponseStatus items * removed the STANDARD_NAMESPACE attribute from ModeSelect XMLs * Update src/app/zap-templates/zcl/data-model/chip/dishwasher-mode-select-cluster.xml Co-authored-by: Boris Zbarsky <[email protected]> * Rnamed the Laundry Washer cluster to match the spec. Removed reading of depricated StandardNamespace in the TestModeSelectCluster.yaml. * Added generated code after merge. * Readded the STANDARD_NAMESPACE attribute to the ModeSelect XML as optional to avoid braking client APIs. * Renamed the laundyr washer XML to match the cluster name as defined in the spec. * Renamed the mode select alias clusters to match the latest spec changes. Fixes issue #26551. * Updated the RVC Run ChangeToModeResponseStatus enums to match the latest spec. * Changed the enum names based on the spec PR 6986. * Added generated code after merge. Updated the mode select example following the renaming of the semantic tags. * Added TagName to the ModeOptionStruct following the spce change in PR 6969. * Depricated the MfgCode in ModeOptionStruct following the spec change in PR 6989. * regenerated zap code. * Generated the zap code. Updated the ModeSelect all-clustres-app example. * Restyled by clang-format * Updated the use of semantic tags. in the esp32 examples. * Regenerated code after merge. * Restyled by clang-format * Regenerated code after merge. * Fixed linux build. * Fixed fake linux build... * Updated the TestModeSelectCluster.yaml to match the new name change. * Added expeted generated files to src/controller/data_model/BUILD.gn and sorted the list. * Restyled by clang-format * Restyled by prettier-yaml * Added generated code * Regenerated code after merge. --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
|
Marking complete |
github-project-automation
bot
moved this from Todo
to Done
in [Enhancements] Spec/XML Alignment
github-project-automation
bot
moved this from Open Cert Blockers
to Complete
in [Certification] Blockers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[Matter 1.2]
The RVC Run cluster was renamed RVC Run Mode Select. The RVC Clean cluster was renamed RVC Clean Mode Select.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6969/files
The SDK must be updated.
The text was updated successfully, but these errors were encountered: