Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify if the <access modifier> xml configuration does anything during the generation process #26316

Closed
mkardous-silabs opened this issue May 1, 2023 · 0 comments · Fixed by #26330
Closed

Verify if the <access modifier> xml configuration does anything during the generation process #26316

mkardous-silabs opened this issue May 1, 2023 · 0 comments · Fixed by #26330

Comments

@mkardous-silabs
Copy link
Contributor

Description

When defining the access configurations for an attribute, it is not clear if the <access modifier> does anything.

See https://github.com/project-chip/connectedhomeip/pull/26302/files#r1180940451 as reference.
@mkardous-silabs mkardous-silabs mentioned this issue May 1, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 2, 2023
@bzbarsky-apple
Remove unused "<access modifier>" bits from XML.
f3a33b6 
Removing these does not change any codegen, either compile-time or for committed
files, so we're not using these for anything.  And they're not consistently
applied to the attributes that are fabric scoped, so if we did try to start
using them we would need to audit to decide where to do that, and not using them
anywhere makes that clear.

Fixes project-chip#26316
@bzbarsky-apple bzbarsky-apple mentioned this issue May 2, 2023
Merged
jmartinez-silabs pushed a commit that referenced this issue May 3, 2023
@bzbarsky-apple
Remove unused "<access modifier>" bits from XML. (#26330)
649c012 
Removing these does not change any codegen, either compile-time or for committed
files, so we're not using these for anything.  And they're not consistently
applied to the attributes that are fabric scoped, so if we did try to start
using them we would need to audit to decide where to do that, and not using them
anywhere makes that clear.

Fixes #26316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused "<access modifier>" bits from XML. bzbarsky-apple/connectedhomeip
1 participant
@mkardous-silabs