Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threadsafety assertion in TestDnssd #26023

Closed
kskenyon opened this issue Apr 7, 2023 · 0 comments · Fixed by #26024
Closed

Threadsafety assertion in TestDnssd #26023

kskenyon opened this issue Apr 7, 2023 · 0 comments · Fixed by #26024

Comments

@kskenyon
Copy link

kskenyon commented Apr 7, 2023

Reproduction steps

./gn_build.sh

Bug prevalence

Always

GitHub hash of the SDK that was being used

Master

Platform

darwin

Platform Version(s)

13.4 Beta (22F5027f)

Anything else?

[1680899552508] [56983:7811128] [DL] Chip stack locking error at 'src/platform/Darwin/DnssdImpl.cpp:425'. Code is unsafe/racy
[1680899552508] [56983:7811128] [-] chipDie chipDie chipDie
../../third_party/pigweed/repo/targets/host/run_test: line 18: 56983 Abort trap: 6 "$@"
INF Test 1/1: [FAIL] TestDnssd in 6.002 s
[2327/3204] ACTION //src/transport/tests:TestSessionManager_run(//build/toolchain/host:mac_arm64_gcc)
ninja: build stopped: subcommand failed.
@bzbarsky-apple bzbarsky-apple changed the title [BUG] Threadsafety assertion in TestDnssd Apr 7, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 7, 2023
@bzbarsky-apple
Fix shutdown ordering in TestDnssd.
48bc4e9 
For init it does, in order: PlatformMgr().InitChipStack(), ChipDnssdInit,
RunEventLoop.

For shutdown it should do them in exactly the opposite order.

Fixes project-chip#26023
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 7, 2023
Merged
bzbarsky-apple added a commit that referenced this issue Apr 11, 2023
@bzbarsky-apple
Fix shutdown ordering in TestDnssd. (#26024)
b5d2e49 
For init it does, in order: PlatformMgr().InitChipStack(), ChipDnssdInit,
RunEventLoop.

For shutdown it should do them in exactly the opposite order.

Fixes #26023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shutdown ordering in TestDnssd. bzbarsky-apple/connectedhomeip
1 participant
@kskenyon