Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update General Commissioning Cluster XML to match updated spec #24997

Closed
ReneJosefsen opened this issue Feb 11, 2023 · 0 comments · Fixed by #26732
Closed

[XML] Update General Commissioning Cluster XML to match updated spec #24997

ReneJosefsen opened this issue Feb 11, 2023 · 0 comments · Fixed by #26732
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@ReneJosefsen
Copy link
Contributor

The data types names has been updated in General Commissioning Cluster and must be updated in the XML as well.

Updated
CommissioningError -> CommissioningErrorEnum
RegulatoryLocationType -> RegulatoryLocationTypeEnum
BasicCommissioningInfo -> BasicCommissioningInfoStruct

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6179 (already merged)
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Feb 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 22, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
d3827bd 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
@bzbarsky-apple bzbarsky-apple mentioned this issue May 22, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 22, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
4767af9 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 22, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
1598464 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 22, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
32bce66 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 23, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
d356ebc 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 23, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes.
07763c8 
Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes project-chip#24997
bzbarsky-apple added a commit that referenced this issue May 23, 2023
@bzbarsky-apple
Align General Commissioning cluster XML to spec changes. (#26732)
9876878 
* Align General Commissioning cluster XML to spec changes.

Spec changes happened in
CHIP-Specifications/connectedhomeip-spec#6179 and
CHIP-Specifications/connectedhomeip-spec#6338

Fixes #24997

* Auto-update ZAP files.

* Regenerate generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align General Commissioning cluster XML to spec changes. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ReneJosefsen