Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop putting deprecated members on the subclass for Darwin command params structs #24542

Closed
bzbarsky-apple opened this issue Jan 20, 2023 · 0 comments · Fixed by #24543
Closed

Stop putting deprecated members on the subclass for Darwin command params structs #24542

bzbarsky-apple opened this issue Jan 20, 2023 · 0 comments · Fixed by #24543
Assignees
@bzbarsky-apple
Labels
darwin v1.1

Comments

@bzbarsky-apple
Copy link
Contributor

I thought I was being clever with this, but this fails when we receive a command (either a response, or we are acting as a server). We create the super-class, then end up casting it to the subclass with comments about how this is safe... but it's not, precisely because the subclass implements selectors the superclass does not.
@bzbarsky-apple bzbarsky-apple self-assigned this Jan 20, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 20, 2023
@bzbarsky-apple
Stop putting selectors on subclasses of command params structs.
35e8f34 
That violates assumptions about being able to cast between the old and
new names.

Fixes project-chip#24542
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 20, 2023
Merged
bzbarsky-apple added a commit that referenced this issue Jan 20, 2023
@bzbarsky-apple
Stop putting selectors on subclasses of command params structs. (#24543)
b1b8fa2 
That violates assumptions about being able to cast between the old and
new names.

Fixes #24542
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Stop putting selectors on subclasses of command params structs. (#24543)
5c3d280 
That violates assumptions about being able to cast between the old and
new names.

Fixes project-chip/connectedhomeip#24542
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Stop putting selectors on subclasses of command params structs. (#24543)
1ac859c 
That violates assumptions about being able to cast between the old and
new names.

Fixes project-chip/connectedhomeip#24542
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Stop putting selectors on subclasses of command params structs. (proj…
73ecb04 
…ect-chip#24543)

That violates assumptions about being able to cast between the old and
new names.

Fixes project-chip#24542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop putting selectors on subclasses of command params structs. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple