Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of TestReadInteraction::TestSubscribeRoundtrip is not testing what it thinks it's testing #23260

Closed
bzbarsky-apple opened this issue Oct 19, 2022 · 0 comments · Fixed by #25298
Closed

End of TestReadInteraction::TestSubscribeRoundtrip is not testing what it thinks it's testing #23260

bzbarsky-apple opened this issue Oct 19, 2022 · 0 comments · Fixed by #25298
Assignees
@bzbarsky-apple

Comments

@bzbarsky-apple
Copy link
Contributor

It's testing that no reports are received, but there's no actual reporting run scheduled, so that's not surprising. Need to ensure that a reporting run gets scheduled there, so the test is meaningful.
@bzbarsky-apple bzbarsky-apple self-assigned this Oct 19, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 24, 2023
@bzbarsky-apple
Make sure various tests in TestReadInteraction are not no-ops.
86dd3f3 
* Switches to setting flags on the ReadHandler using the method that will schedule reporting runs as needed.
* Adds asserts that a run has in fact been scheduled in various places.

Fixes project-chip#23260
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 24, 2023
Merged
andy31415 pushed a commit that referenced this issue Feb 28, 2023
@bzbarsky-apple
Make sure various tests in TestReadInteraction are not no-ops. (#25298)
dc7165b 
* Switches to setting flags on the ReadHandler using the method that will schedule reporting runs as needed.
* Adds asserts that a run has in fact been scheduled in various places.

Fixes #23260
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Make sure various tests in TestReadInteraction are not no-ops. (#25298)
1f50647 
* Switches to setting flags on the ReadHandler using the method that will schedule reporting runs as needed.
* Adds asserts that a run has in fact been scheduled in various places.

Fixes project-chip/connectedhomeip#23260
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Make sure various tests in TestReadInteraction are not no-ops. (proje…
b843d1e 
…ct-chip#25298)

* Switches to setting flags on the ReadHandler using the method that will schedule reporting runs as needed.
* Adds asserts that a run has in fact been scheduled in various places.

Fixes project-chip#23260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure various tests in TestReadInteraction are not no-ops. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple