Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] scripts/bootstrap.sh should do a git submodule sync #23059

Closed
jtung-apple opened this issue Oct 6, 2022 · 0 comments · Fixed by #23095
Closed

[Core] scripts/bootstrap.sh should do a git submodule sync #23059

jtung-apple opened this issue Oct 6, 2022 · 0 comments · Fixed by #23095

Comments

@jtung-apple
Copy link
Contributor

jtung-apple commented Oct 6, 2022

Reproduction steps / Feature

When a git submodule updates its url in .gitmodules, bootstrap.sh would start failing to update the submodule.

Adding a git submodule sync should fix this.

Platform

core (please add to version below)

Platform Version(s)

1.0

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

Encountered this after #22864 went in.

Anything else?

No response

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 10, 2022
When submodule URLs change, re-bootstrap will fail unless something does "git
submodule sync".  We should just do that as part of bootstrap, instead of
assuming that developers know to do it.

Fixes project-chip#23059
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 10, 2022
When submodule URLs change, re-bootstrap will fail unless something does "git
submodule sync".  We should just do that as part of bootstrap, instead of
assuming that developers know to do it.

Fixes project-chip#23059
bzbarsky-apple added a commit that referenced this issue Oct 11, 2022
When submodule URLs change, re-bootstrap will fail unless something does "git
submodule sync".  We should just do that as part of bootstrap, instead of
assuming that developers know to do it.

Fixes #23059
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Oct 12, 2022
When submodule URLs change, re-bootstrap will fail unless something does "git
submodule sync".  We should just do that as part of bootstrap, instead of
assuming that developers know to do it.

Fixes project-chip#23059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant