Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaPlayback definition does not include the feature map global attribute #22681

Closed
cjswedes opened this issue Sep 15, 2022 · 0 comments · Fixed by #22804
Closed

MediaPlayback definition does not include the feature map global attribute #22681

cjswedes opened this issue Sep 15, 2022 · 0 comments · Fixed by #22804
Labels
tv TV-related features

Comments

@cjswedes
Copy link
Contributor

cjswedes commented Sep 15, 2022 •
edited
Loading

Reproduction steps

The xml definition is incomplete. The spec defines a feature map for this cluster, but it is not in the xml definition.
Whenever the zap tool is used with this cluster definition, a feature map is not included

Anything else?

I am referencing this xml definition: https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/media-playback-cluster.xml
@bzbarsky-apple bzbarsky-apple added the tv TV-related features label Sep 21, 2022
cjswedes added a commit to cjswedes/connectedhomeip that referenced this issue Sep 21, 2022
@cjswedes
Add MediaPlayback feature map to zcl xml definition
51004bd 
Fixes Issue project-chip#22681
@cjswedes cjswedes mentioned this issue Sep 21, 2022
Merged
cjswedes added a commit to cjswedes/connectedhomeip that referenced this issue Sep 22, 2022
@cjswedes
Add MediaPlayback feature map to zcl xml definition
9ebbd33 
Fixes Issue project-chip#22681
cjswedes added a commit to cjswedes/connectedhomeip that referenced this issue Sep 23, 2022
@cjswedes
Add MediaPlayback feature map to zcl xml definition
1e3dbc4 
Fixes Issue project-chip#22681
saurabhst pushed a commit that referenced this issue Sep 23, 2022
@cjswedes
Fix Switch and MediaPlayback feature map zcl definitions (#22804)
977cfa4 
* Add MediaPlayback feature map to zcl xml definition

Fixes Issue #22681

* Link SwitchFeature to cluster for zap tool usage

Fixes Issue #22802

* Zap regeneration for MediaPlayback and Switch Featuremap addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tv TV-related features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Switch and MediaPlayback feature map zcl definitions cjswedes/connectedhomeip
2 participants
@cjswedes @bzbarsky-apple