Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Apply API review fixes for MTROTAHeaderParser #22540

Closed
bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22611
Closed

[Platform] Apply API review fixes for MTROTAHeaderParser #22540

bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22611
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 12, 2022 •
edited
Loading

Reproduction steps

  1. Document the API.
  2. Make properties copy instead of strong.
  3. Move headerFromData to MTROTAHeader.

Part of #22420 and pretty independent of the other pieces.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 12, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 14, 2022
@bzbarsky-apple
Apply API review fixes for MTROTAHeaderParser.
7a45cd5 
* Move the parsing method to MTROTAHeader.
* Rename the file to MTROTAHeader.h
* Add documentation.
* Make the properties that can be missing nullable.
* Make properties copy instead of strong.

Fixes project-chip#22540

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 14, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Sep 14, 2022
@bzbarsky-apple
Apply API review fixes for MTROTAHeaderParser. (#22611)
8c4675f 
* Move the parsing method to MTROTAHeader.
* Rename the file to MTROTAHeader.h
* Add documentation.
* Make the properties that can be missing nullable.
* Make properties copy instead of strong.

Fixes #22540

Addresses part of #22420
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Apply API review fixes for MTROTAHeaderParser. (project-chip#22611)
49425ba 
* Move the parsing method to MTROTAHeader.
* Rename the file to MTROTAHeader.h
* Add documentation.
* Make the properties that can be missing nullable.
* Make properties copy instead of strong.

Fixes project-chip#22540

Addresses part of project-chip#22420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply API review fixes for MTROTAHeaderParser. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple