Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop trying to update addresses for non-CASE sessions #22326

Closed
bzbarsky-apple opened this issue Aug 31, 2022 · 0 comments · Fixed by #22327
Closed

Stop trying to update addresses for non-CASE sessions #22326

bzbarsky-apple opened this issue Aug 31, 2022 · 0 comments · Fixed by #22327

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We try to update the address for non-CASE sessions (because the checks for "is this session that failed to deliver a message a CASE session?" got lost during the CASE refactors). This at best leads to spurious error logs and at worst leads to extra dns-sd traffic that actually makes the delivery problems worse.

Proposed Solution

Add back the "is this CASE?" checks.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 31, 2022
@bzbarsky-apple
Only do address updates for CASE delivery failures.
ad09dd8 
When the handling of "failed to send message, so update the IP for this peer"
moved out of DeviceCommissioner, we stopped checking whether the session is a
CASE session.  Go back to checking that again.

Fixes project-chip#22326
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 31, 2022
Merged
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Only do address updates for CASE delivery failures. (project-chip#22327)
30a0578 
* Only do address updates for CASE delivery failures.

When the handling of "failed to send message, so update the IP for this peer"
moved out of DeviceCommissioner, we stopped checking whether the session is a
CASE session.  Go back to checking that again.

Fixes project-chip#22326

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only do address updates for CASE delivery failures. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple