Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Commissioning Cluster status codes are not spec compliant #21887

Closed
tcarmelveilleux opened this issue Aug 15, 2022 · 0 comments · Fixed by #21890
Closed

Admin Commissioning Cluster status codes are not spec compliant #21887

tcarmelveilleux opened this issue Aug 15, 2022 · 0 comments · Fixed by #21890
Assignees
@tcarmelveilleux
Labels
request cert blocker spec Mismatch between spec and implementation V1.0

Comments

@tcarmelveilleux
Copy link
Contributor

Problem

Since https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5330, status codes for Admin Commissioning cluster have been increased by 1. SDK still uses the old version.

Proposed Solution

  • Fix the enum
@tcarmelveilleux tcarmelveilleux added spec Mismatch between spec and implementation looks_critical request cert blocker V1.0 labels Aug 15, 2022
@tcarmelveilleux tcarmelveilleux self-assigned this Aug 15, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Aug 15, 2022
@tcarmelveilleux
Fix enums in admin commissioning cluster
cb94003 
- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes project-chip#21887

Testing done:
- Unit tests still pass
- Cert tests still pass
@tcarmelveilleux tcarmelveilleux mentioned this issue Aug 15, 2022
Merged
woody-apple added a commit that referenced this issue Aug 16, 2022
@tcarmelveilleux @woody-apple
Fix enums in admin commissioning cluster (#21890)
c24577d 
* Fix enums in admin commissioning cluster

- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes #21887

Testing done:
- Unit tests still pass
- Cert tests still pass

* Update some tests to validate new codes

Co-authored-by: Justin Wood <[email protected]>
woody-apple added a commit that referenced this issue Aug 16, 2022
@tcarmelveilleux @woody-apple
Fix enums in admin commissioning cluster (#21890)
a2031c5 
* Fix enums in admin commissioning cluster

- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes #21887

Testing done:
- Unit tests still pass
- Cert tests still pass

* Update some tests to validate new codes

Co-authored-by: Justin Wood <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@tcarmelveilleux @woody-apple @isiu-apple
Fix enums in admin commissioning cluster (project-chip#21890)
41ba5cf 
* Fix enums in admin commissioning cluster

- Enum of cluster custom codes was not following spec
- This PR updates the enum values

Fixes project-chip#21887

Testing done:
- Unit tests still pass
- Cert tests still pass

* Update some tests to validate new codes

Co-authored-by: Justin Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
request cert blocker spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix enums in admin commissioning cluster tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux