-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip-tool levelcontrol misses mandatory parameters for some commands #21294
Labels
Comments
BTW, it looks like the mandatory parameters are not even sent to the DUT - assuming I interpret this correctly - it has 2 entries in CommandFields where I expect 4 - so it's "interesting" how the receiving end will work in lack of mandatory parameters
|
robszewczyk
added a commit
to robszewczyk/connectedhomeip
that referenced
this issue
Jul 27, 2022
* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride * add missing optional parameters to the command variants `WithOnOnff` The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9 Fixes project-chip#21294
This was referenced Jul 27, 2022
Merged
robszewczyk
added a commit
that referenced
this issue
Jul 28, 2022
…ec and the test spec (#21312) * Bring Level Control cluster in line with the spec * rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride * add missing parameters to the command variants `WithOnOnff` The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9 Fixes #21294 Co-authored-by: Justin Wood <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
Jul 28, 2022
…ec and the test spec (#21312) * Bring Level Control cluster in line with the spec * rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride * add missing parameters to the command variants `WithOnOnff` The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9 Fixes #21294 Co-authored-by: Justin Wood <[email protected]>
woody-apple
added a commit
that referenced
this issue
Jul 29, 2022
…ec and the test spec (#21312) (#21379) * Bring Level Control cluster in line with the spec * rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride * add missing parameters to the command variants `WithOnOnff` The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9 Fixes #21294 Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Robert Szewczyk <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this issue
Sep 16, 2022
…ec and the test spec (project-chip#21312) * Bring Level Control cluster in line with the spec * rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride * add missing parameters to the command variants `WithOnOnff` The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9 Fixes project-chip#21294 Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
chip-tool levelcontrol
misses the parametersOptionsMask
andOptionsOverride
for the four 'with-on-off` commandsThese parameters are essential for some tests (TC-LVL-* after PR 1893)
Also, for the other four commands, these parameters are present but misspelled (the '
s
' is missing)Proposed Solution
From chip-tool's integrated help: (added spaces for clear presetation)
The text was updated successfully, but these errors were encountered: