Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chip-tool levelcontrol misses mandatory parameters for some commands #21294

Closed
leorozendaal opened this issue Jul 27, 2022 · 1 comment · Fixed by #21312
Closed

chip-tool levelcontrol misses mandatory parameters for some commands #21294

leorozendaal opened this issue Jul 27, 2022 · 1 comment · Fixed by #21312
Assignees

Comments

@leorozendaal
Copy link
Contributor

leorozendaal commented Jul 27, 2022

Problem

chip-tool levelcontrol misses the parameters OptionsMask and OptionsOverride for the four 'with-on-off` commands
These parameters are essential for some tests (TC-LVL-* after PR 1893)

Also, for the other four commands, these parameters are present but misspelled (the 's' is missing)

Proposed Solution

  • Add two parameter to four commands
  • Fix parameter names for four commands

From chip-tool's integrated help: (added spaces for clear presetation)

./chip-tool levelcontrol move-to-level             Level TransitionTime OptionMask OptionOverride destination-id
./chip-tool levelcontrol move-to-level-with-on-off Level TransitionTime                           destination-id

./chip-tool levelcontrol move             MoveMode Rate OptionMask OptionOverride destination-id
./chip-tool levelcontrol move-with-on-off MoveMode Rate                           destination-id

./chip-tool levelcontrol step             StepMode StepSize TransitionTime OptionMask OptionOverride destination-id
./chip-tool levelcontrol step-with-on-off StepMode StepSize TransitionTime                           destination-id

./chip-tool levelcontrol stop             OptionMask OptionOverride destination-id ...
./chip-tool levelcontrol stop-with-on-off                           destination-id ...
@leorozendaal
Copy link
Contributor Author

leorozendaal commented Jul 27, 2022

BTW, it looks like the mandatory parameters are not even sent to the DUT - assuming I interpret this correctly - it has 2 entries in CommandFields where I expect 4 - so it's "interesting" how the receiving end will work in lack of mandatory parameters

[1658953920.378766][5336:5342] CHIP:DMG: InvokeRequestMessage =
[1658953920.378792][5336:5342] CHIP:DMG: {
[1658953920.378813][5336:5342] CHIP:DMG:        suppressResponse = false,
[1658953920.378836][5336:5342] CHIP:DMG:        timedRequest = false,
[1658953920.378855][5336:5342] CHIP:DMG:        InvokeRequests =
[1658953920.378887][5336:5342] CHIP:DMG:        [
[1658953920.378906][5336:5342] CHIP:DMG:                CommandDataIB =
[1658953920.378929][5336:5342] CHIP:DMG:                {
[1658953920.378949][5336:5342] CHIP:DMG:                        CommandPathIB =
[1658953920.378971][5336:5342] CHIP:DMG:                        {
[1658953920.378993][5336:5342] CHIP:DMG:                                EndpointId = 0x2,
[1658953920.379016][5336:5342] CHIP:DMG:                                ClusterId = 0x8,
[1658953920.379037][5336:5342] CHIP:DMG:                                CommandId = 0x4,
[1658953920.379056][5336:5342] CHIP:DMG:                        },
[1658953920.379080][5336:5342] CHIP:DMG:
[1658953920.379101][5336:5342] CHIP:DMG:                        CommandFields =
[1658953920.379123][5336:5342] CHIP:DMG:                        {
[1658953920.379172][5336:5342] CHIP:DMG:                                0x0 = 3,
[1658953920.379195][5336:5342] CHIP:DMG:                                0x1 = 0,
[1658953920.379217][5336:5342] CHIP:DMG:                        },
[1658953920.379236][5336:5342] CHIP:DMG:                },
[1658953920.379264][5336:5342] CHIP:DMG:
[1658953920.379283][5336:5342] CHIP:DMG:        ],

robszewczyk added a commit to robszewczyk/connectedhomeip that referenced this issue Jul 27, 2022
* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing optional parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes project-chip#21294
robszewczyk added a commit that referenced this issue Jul 28, 2022
…ec and the test spec (#21312)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes #21294

Co-authored-by: Justin Wood <[email protected]>
github-actions bot pushed a commit that referenced this issue Jul 28, 2022
…ec and the test spec (#21312)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes #21294

Co-authored-by: Justin Wood <[email protected]>
woody-apple added a commit that referenced this issue Jul 29, 2022
…ec and the test spec (#21312) (#21379)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes #21294

Co-authored-by: Justin Wood <[email protected]>

Co-authored-by: Robert Szewczyk <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
…ec and the test spec (project-chip#21312)

* Bring Level Control cluster in line with the spec

* rename misspelled parameters: optionMask -> optionsMask, optionOverride->optionsOverride
* add missing parameters to the command variants `WithOnOnff`

The discrepancy with the spec stemmed from the old version of the level control being used, the version included previously appeared to track "zcl6-errata-14-0129-15" as opposed to ZCL9

Fixes project-chip#21294

Co-authored-by: Justin Wood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants