Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PASE enums used in the SDK do not match the spec #21128

Closed
bluebin14 opened this issue Jul 22, 2022 · 0 comments · Fixed by #21239
Closed

PASE enums used in the SDK do not match the spec #21128

bluebin14 opened this issue Jul 22, 2022 · 0 comments · Fixed by #21239
Labels
spec Mismatch between spec and implementation

Comments

@bluebin14
Copy link
Contributor

Problem

PASE enums used in the SDK do not match the spec. In particular PASE_PakeError has been removed long ago from the spec and replaced by StatusReport.

Proposed Solution

Align SDK with the spec.
@bluebin14 bluebin14 added the spec Mismatch between spec and implementation label Jul 22, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
@bzbarsky-apple
Remove the PakeError message type.
056b82d 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes project-chip#21128
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 26, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
@bzbarsky-apple
Remove the PakeError message type.
d7838ac 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes project-chip#21128
woody-apple pushed a commit that referenced this issue Jul 27, 2022
@bzbarsky-apple
Remove the PakeError message type. (#21239)
bd5924d 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128
github-actions bot pushed a commit that referenced this issue Jul 27, 2022
@bzbarsky-apple @web-flow
Remove the PakeError message type. (#21239)
9c04a64 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128
@woody-apple woody-apple mentioned this issue Jul 27, 2022
Merged
woody-apple added a commit that referenced this issue Jul 28, 2022
@woody-apple @bzbarsky-apple
Remove the PakeError message type. (#21239) (#21300)
9ab1a94 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes #21128

Co-authored-by: Boris Zbarsky <[email protected]>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Remove the PakeError message type. (project-chip#21239)
1bf7a83 
It's been gone from the spec for a while; we should remove it from the SDK too.

Fixes project-chip#21128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the PakeError message type. bzbarsky-apple/connectedhomeip
1 participant
@bluebin14