Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pre-SVE] TC-DRLK-1.1 Not all SCH commands supported #19793

Closed
HubertHugo opened this issue Jun 21, 2022 · 6 comments · Fixed by #20670
Closed

[Pre-SVE] TC-DRLK-1.1 Not all SCH commands supported #19793

HubertHugo opened this issue Jun 21, 2022 · 6 comments · Fixed by #20670
Assignees
Labels
app-clusters Application cluster work cert blocker

Comments

@HubertHugo
Copy link
Contributor

SHA: 1e3f120
platform: nRF25840
all-clusters-app

Feature map suggests DUT supports SCH

[1655798752.723920][8565:8570] CHIP:TOO:   FeatureMap: 275

but

[1655799565.423198][9116:9121] CHIP:TOO:   AcceptedCommandList: 14 entries
[1655799565.423218][9116:9121] CHIP:TOO:     [1]: 0
[1655799565.423230][9116:9121] CHIP:TOO:     [2]: 1
[1655799565.423240][9116:9121] CHIP:TOO:     [3]: 3
[1655799565.423252][9116:9121] CHIP:TOO:     [4]: 11
[1655799565.423262][9116:9121] CHIP:TOO:     [5]: 12
[1655799565.423274][9116:9121] CHIP:TOO:     [6]: 13
[1655799565.423283][9116:9121] CHIP:TOO:     [7]: 14
[1655799565.423294][9116:9121] CHIP:TOO:     [8]: 15
[1655799565.423303][9116:9121] CHIP:TOO:     [9]: 26
[1655799565.423315][9116:9121] CHIP:TOO:     [10]: 27
[1655799565.423327][9116:9121] CHIP:TOO:     [11]: 29
[1655799565.423338][9116:9121] CHIP:TOO:     [12]: 34
[1655799565.423349][9116:9121] CHIP:TOO:     [13]: 36
[1655799565.423360][9116:9121] CHIP:TOO:     [14]: 38
[1655799775.519924][9177:9182] CHIP:TOO:   GeneratedCommandList: 5 entries
[1655799775.519930][9177:9182] CHIP:TOO:     [1]: 12
[1655799775.519935][9177:9182] CHIP:TOO:     [2]: 15
[1655799775.519939][9177:9182] CHIP:TOO:     [3]: 28
[1655799775.519943][9177:9182] CHIP:TOO:     [4]: 35
[1655799775.519946][9177:9182] CHIP:TOO:     [5]: 37

dont include mandatory for SCH
Accepted: 0x10, 0x11, 0x12, 0x13
Generated: 0x12

@bzbarsky-apple
Copy link
Contributor

The spec here is changing and the SCH bit is getting split up into multiple features, which are independent. We do need to update the implementation to that, though.

@Morozov-5F

@woody-apple
Copy link
Contributor

Cert Blocker Review: This appears like the SDK needs to update, @Morozov-5F can you take a peek at this?

@Morozov-5F
Copy link
Contributor

Well that's all-clusters-app, lock-app supports all the schedule features at once

@bzbarsky-apple
Copy link
Contributor

@Morozov-5F We still need to implement the three different schedule feature bits in the feature map, right?

@andy31415
Copy link
Contributor

Could we make all-clusters not report a featuremap supporting these features? lock app can .

@Morozov-5F
Copy link
Contributor

@Morozov-5F We still need to implement the three different schedule feature bits in the feature map, right?

@bzbarsky-apple oh, forgot about that, thanks

Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue Jul 13, 2022
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue Jul 13, 2022
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue Jul 13, 2022
andy31415 pushed a commit that referenced this issue Jul 15, 2022
* [#19793] Implement separate feature bits for schedules in the door lock cluster

* Update auto-generated files
github-actions bot pushed a commit that referenced this issue Jul 15, 2022
* [#19793] Implement separate feature bits for schedules in the door lock cluster

* Update auto-generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work cert blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants