Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] pump controller app cluster definitions not up to spec #19178

Closed
andy31415 opened this issue Jun 3, 2022 · 2 comments
Closed

[spec] pump controller app cluster definitions not up to spec #19178

andy31415 opened this issue Jun 3, 2022 · 2 comments
Labels
lint

Comments

@andy31415
Copy link
Contributor

Problem

./scripts/idl_lint.py --log-level warn ./examples/pump-controller-app/pump-controller-common/pump-controller-app.matter
2022-06-03 10:18:34 ERROR   ERROR: Required attributes: EP0:OtaSoftwareUpdateRequestor does not expose DefaultOtaProviders(0) attribute at ./examples/pump-controller-app/pump-controller-common/pump-controller-app.matter:1364:3
2022-06-03 10:18:34 ERROR   Found 1 lint errors
@andy31415 andy31415 added the lint label Jun 3, 2022
tlykkeberg-grundfos added a commit to Grundfos/connectedhomeip that referenced this issue Jun 8, 2022
@tlykkeberg-grundfos
* Reworked the entire pcc controller zap file to be spec compliant
2f7e367 
* Fixed issue project-chip#19178
@tlykkeberg-grundfos tlykkeberg-grundfos mentioned this issue Jun 8, 2022
Merged
andy31415 pushed a commit that referenced this issue Jun 18, 2022
@tlykkeberg-grundfos
[example] PCC pump-controller-app zap-file fixup (#19314)
2c7105c 
* * Reworked the entire pcc controller zap file to be spec compliant
* Fixed issue #19178

* * Re-ran the zap_regen_all.py tool
@ReneJosefsen
Copy link
Contributor

@andy31415, seems like the PR was not linked to the issue properly but I think this issue can be closed?

@andy31415
Copy link
Contributor Author

Tested today, ./scripts/idl_lint.py --log-level warn ./examples/pump-controller-app/pump-controller-common/pump-controller-app.matter gives no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andy31415 @ReneJosefsen