Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] Open Commissioning Window APIs need to be async #18527

Closed
sagar-apple opened this issue May 17, 2022 · 1 comment · Fixed by #22521
Closed

[Darwin] Open Commissioning Window APIs need to be async #18527

sagar-apple opened this issue May 17, 2022 · 1 comment · Fixed by #22521
Assignees
@bzbarsky-apple
Labels
darwin v1.1

Comments

@sagar-apple
Copy link
Contributor

Problem

The current openPairingWindow and openPairingWindowWithPIN APIs exposed to Darwin clients are not really usable.
These APIs are synchronous and will always succeed.

For example, repeated calls to openPairingWindowWithPIN appear to work whereas the server cannot honor these until the previous duration has expired and so it returns an error. That error is never returned to the Darwin client.

Proposed Solution

We should make these async since they represent a remote request on the server
@bzbarsky-apple
Copy link
Contributor

The changes for #22420 will likely fix this.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 9, 2022
@bzbarsky-apple
Fix Darwin APIs for opening commissioning windows per API review.
53ac6c9 
Fixes project-chip#18527

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 9, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 10, 2022
@bzbarsky-apple
Fix Darwin APIs for opening commissioning windows per API review.
6b1c2e5 
Fixes project-chip#18527

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 12, 2022
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 12, 2022
Closed
franck-apple pushed a commit that referenced this issue Sep 12, 2022
@bzbarsky-apple
Fix Darwin APIs for opening commissioning windows per API review. (#2…
b89aa66 
…2521)

Fixes #18527

Addresses part of #22420
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Fix Darwin APIs for opening commissioning windows per API review. (pr…
e3a0118 
…oject-chip#22521)

Fixes project-chip#18527

Addresses part of project-chip#22420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Darwin APIs for opening commissioning windows per API review. bzbarsky-apple/connectedhomeip
3 participants
@woody-apple @sagar-apple @bzbarsky-apple