Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some logs from INFO to ERROR since they expose actual issues #18384

Closed
dnicoara opened this issue May 12, 2022 · 0 comments · Fixed by #18577
Closed

Update some logs from INFO to ERROR since they expose actual issues #18384

dnicoara opened this issue May 12, 2022 · 0 comments · Fixed by #18577
Assignees
@tcarmelveilleux
Labels
commissioning Involves placing devices on the network, initial setup

Comments

@dnicoara
Copy link
Contributor

Problem

Errors such as the following are logged as INFO:

I (52610) chip[ZCL]: OpCreds: Failed AddNOC request. Status 9

Proposed Solution

Since these do expose real issues, they should be logged as ERROR.
@tcarmelveilleux tcarmelveilleux self-assigned this May 12, 2022
@tcarmelveilleux tcarmelveilleux added V1.0 commissioning Involves placing devices on the network, initial setup labels May 12, 2022
@andy31415 andy31415 removed the V1.0 label May 12, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue May 18, 2022
@tcarmelveilleux
Normalize NOC cluster logs
5f7a257 
- NOC cluster was using Info/Debug verbosity for errors
- NOC cluster was not logging sufficient info for some errors
- NOC cluster had a variety of asymmetrical log formats related
  to multiple authors.
- NOC cluster was using emberAfPrintln() instead of ChipLog*()

This PR cleans up the logging and normalizes it

Fixes project-chip#18384

Testing done:
- Unit tests and cert tests pass
- Logging audited on a cert test run for funkiness, none found
@tcarmelveilleux tcarmelveilleux mentioned this issue May 18, 2022
Merged
tcarmelveilleux added a commit that referenced this issue May 19, 2022
@tcarmelveilleux @restyled-commits
Normalize NOC cluster logs (#18577)
6fc3432 
* Normalize NOC cluster logs

- NOC cluster was using Info/Debug verbosity for errors
- NOC cluster was not logging sufficient info for some errors
- NOC cluster had a variety of asymmetrical log formats related
  to multiple authors.
- NOC cluster was using emberAfPrintln() instead of ChipLog*()

This PR cleans up the logging and normalizes it

Fixes #18384

Testing done:
- Unit tests and cert tests pass
- Logging audited on a cert test run for funkiness, none found

* Restyled by clang-format

* Apply review comments

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
commissioning Involves placing devices on the network, initial setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize NOC cluster logs tcarmelveilleux/connectedhomeip
3 participants
@tcarmelveilleux @andy31415 @dnicoara