Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change chipZclProcessIncoming to use the same data format as the chip-zcl-zpro command encoder/decoder #1643

Closed
bzbarsky-apple opened this issue Jul 17, 2020 · 1 comment · Fixed by #1645
Closed

Change chipZclProcessIncoming to use the same data format as the chip-zcl-zpro command encoder/decoder #1643

bzbarsky-apple opened this issue Jul 17, 2020 · 1 comment · Fixed by #1645
Assignees
@bzbarsky-apple

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We temporarily have some sample apps (e.g. the nrf5 lock app) using the old data model and some using the new one, after #1609, and chip-tool won't work with the former.

Proposed Solution

Change chipZclProcessIncoming to use the same data format.

I'll try writing the patch, but I'm not quite sure how to test the fix on my end; not sure I have nrf5 hardware offhand...

@pan-apple @erjiaqing @mspang you all seem to have touched the nrf5 code somewhat, so tagging you just in case.
@bzbarsky-apple bzbarsky-apple self-assigned this Jul 17, 2020
@bzbarsky-apple
Copy link
Contributor Author

Fwiw, I figured out a way to test this: compile the M5Stack echo server against the old data model and the changed decoder for it, then compile chip-tool against the new data model, and check whether they work nicely together.

@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 17, 2020
Merged
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this issue Mar 18, 2024
@jmartinez-silabs
Pull request project-chip#1648: [Cherry-pick] Provision 2.0 with late…
eae4864 
…st fixes

Merge in WMN_TOOLS/matter from cherry-pick/provision_2.0 to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 087b18e961396a50fc769b38f2c2ee1009dab588
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:34:39 2024 +0000

    Pull request project-chip#1645: Bugfix: Provision: README typos.

    Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

    Squashed commit of the following:

    commit d09303c35e73e0068f07973b8933fb9e97d9ddee
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 11:38:01 2024 -0400

        Bugfix: Provision: README typos.

commit 5356620caa1140925915d07cdb17322629c12373
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:28:34 2024 +0000

    Merge pull request project-chip#1646 in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Auto-Merge: Pull request project-chip#1646: [AUTO] Bugfix: Provision: Backwards-compatible header moved to the temp folder.

    Merge in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 8e005e302ea19e280e8ad88f0dd3605450021b96
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 15:11:38 2024 -0400

        Bugfix: Provision: Backwards-compatible header moved to the temp folder.

commit 9a1927cd9c5d0d2e93e3093c8b91da91eac10eaf
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 19:01:30 2024 +0000

    Pull request project-chip#1643: Bugfix: Provision defaults.

    Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
    Author: Ricardo Casallas <[email protected]>
    Date:   Thu Mar 14 10:17:52 2024 -0400

        Bugfix: Provision defaults.

... and 1 more commit
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue May 8, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1643: Bugfix: Provision defaults.
ae594f3 
Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

Squashed commit of the following:

commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 10:17:52 2024 -0400

    Bugfix: Provision defaults.
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#1648: [Cherry-pick] Provision 2.0 with late…
d61d024 
…st fixes

Merge in WMN_TOOLS/matter from cherry-pick/provision_2.0 to RC_2.3.0-1.3-alpha.3

Squashed commit of the following:

commit 087b18e961396a50fc769b38f2c2ee1009dab588
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:34:39 2024 +0000

    Pull request project-chip#1645: Bugfix: Provision: README typos.

    Merge in WMN_TOOLS/matter from bugfix/provision_readme to RC_2.3.0-1.3

    Squashed commit of the following:

    commit d09303c35e73e0068f07973b8933fb9e97d9ddee
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 11:38:01 2024 -0400

        Bugfix: Provision: README typos.

commit 5356620caa1140925915d07cdb17322629c12373
Author: Ricardo Casallas <[email protected]>
Date:   Fri Mar 15 20:28:34 2024 +0000

    Merge pull request project-chip#1646 in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Auto-Merge: Pull request project-chip#1646: [AUTO] Bugfix: Provision: Backwards-compatible header moved to the temp folder.

    Merge in WMN_TOOLS/matter from bugfix/provision_silabs_header to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 8e005e302ea19e280e8ad88f0dd3605450021b96
    Author: Ricardo Casallas <[email protected]>
    Date:   Fri Mar 15 15:11:38 2024 -0400

        Bugfix: Provision: Backwards-compatible header moved to the temp folder.

commit 9a1927cd9c5d0d2e93e3093c8b91da91eac10eaf
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 19:01:30 2024 +0000

    Pull request project-chip#1643: Bugfix: Provision defaults.

    Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

    Squashed commit of the following:

    commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
    Author: Ricardo Casallas <[email protected]>
    Date:   Thu Mar 14 10:17:52 2024 -0400

        Bugfix: Provision defaults.

... and 1 more commit
rcasallas-silabs added a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#1643: Bugfix: Provision defaults.
4faad8e 
Merge in WMN_TOOLS/matter from bugfix/provision-defaults to RC_2.3.0-1.3

Squashed commit of the following:

commit 3eeeb2a30fbdc8cb8a6a992f3f343e47993ad891
Author: Ricardo Casallas <[email protected]>
Date:   Thu Mar 14 10:17:52 2024 -0400

    Bugfix: Provision defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bzbarsky-apple