Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TE8][TC-IDM-2.2] step 5 fails because wildcard reads can easily take longer than 10 seconds #16118

Closed
bauerschwan opened this issue Mar 11, 2022 · 4 comments
Closed

[TE8][TC-IDM-2.2] step 5 fails because wildcard reads can easily take longer than 10 seconds #16118

bauerschwan opened this issue Mar 11, 2022 · 4 comments

Comments

@bauerschwan
Copy link
Contributor

When using wildcard reads with chip-tool then the internal 10 second timeout for such a read command is sometimes not enough because such reads can return many, many objects depending on the device.
The timeout behaviour should be handled differently and - in case of tools like chip-tool - should be changeable by a command line option.
@bauerschwan
Copy link
Contributor Author

Also note that the verification steps for this step is wrong. It should be
chip-tool any read-by-id 0xFFFFFFFF 0xFFFFFFFF 1 0xFFFF to match the test case description

@bzbarsky-apple
Copy link
Contributor

Please file an issue in https://github.com/CHIP-Specifications/chip-test-plans on the test plan verification step being wrong?

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 11, 2022
@bzbarsky-apple
Make the IM command timeouts in chip-tool configurable.
e84826d 
Adds a --timeout optional command-line argument (to match the one that
test commands have).

Also changes the default timeout for read/subscribe from 10s to 30s,
because wildcard read/subscribe can take a while.

project-chip#16118
@bauerschwan
Copy link
Contributor Author

Done: https://github.com/CHIP-Specifications/chip-test-plans/issues/938

@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 11, 2022
Merged
woody-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this issue Mar 11, 2022
@bzbarsky-apple
Make the IM command timeouts in chip-tool configurable.
337cb9c 
Adds a --timeout optional command-line argument (to match the one that
test commands have).

Also changes the default timeout for read/subscribe from 10s to 30s,
because wildcard read/subscribe can take a while.

project-chip#16118
bzbarsky-apple added a commit that referenced this issue Mar 15, 2022
@bzbarsky-apple
Make the IM command timeouts in chip-tool configurable. (#16122)
0b64326 
Adds a --timeout optional command-line argument (to match the one that
test commands have).

Also changes the default timeout for read/subscribe from 10s to 30s,
because wildcard read/subscribe can take a while.

#16118
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Make the IM command timeouts in chip-tool configurable. (project-chip…
8587a7e 
…#16122)

Adds a --timeout optional command-line argument (to match the one that
test commands have).

Also changes the default timeout for read/subscribe from 10s to 30s,
because wildcard read/subscribe can take a while.

project-chip#16118
@mrjerryjohns
Copy link
Contributor

Sounds like this was completed when the support was added to chip-tool to specify a timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrjerryjohns @bzbarsky-apple @bauerschwan